Bug#607867: grub-common: shouty "XEN" in menu items

Colin Watson cjwatson at ubuntu.com
Fri Dec 31 22:50:57 UTC 2010


On Sat, Dec 25, 2010 at 01:53:31PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 12/23/2010 12:56 PM, Colin Watson wrote:
> > On Thu, Dec 23, 2010 at 09:23:15AM +0000, Ian Campbell wrote:
> >> update-grub currently produces menu items like:
> >> 	'Debian GNU/Linux, with Linux 2.6.32-5-xen-amd64 and XEN 4.0-amd64'
> >>
> >> There is no reason to capitalise Xen in that way and IMHO it looks strange.
> >>
> >> The attached patch switches to:
> >> 	'Debian GNU/Linux, with Xen 4.0-amd64 and Linux 2.6.32-5-xen-amd64'
> >>
> >> I moved Xen first since I think it makes it clearer that a given menu item
> >> launches Xen, which is useful information to put up front. Also I found that
> >> with the long Linux version numbers Debian uses the Xen was very nearly off the
> >> edge of the screen.
> >
> > Makes sense to me.  Vladimir, you wrote this script - do you agree?
> 
> Ok with me. You can change it in trunk.

Thanks.  Ian, I've applied both your patches to trunk (extending your
ChangeLog entry to cover the second as well); they'll be in the next
snapshot.

2010-12-31  Ian Campbell <ijc at hellion.org.uk>

	* util/grub.d/20_linux_xen.in (linux_entry): Correctly capitalize
	Xen and reorder menu item wording to make it clearer that this entry
	will launch Xen.  Print separate messages when loading Xen and
	Linux.

-- 
Colin Watson                                       [cjwatson at ubuntu.com]





More information about the Pkg-grub-devel mailing list