Bug#587790: grub-pc: upgrade-from-grub-legacy exits with success (and deletes grub1) even when grub-setup fails

[Colin Watson]

On Thu, Jul 01, 2010 at 06:29:46PM +0200, Lionel Elie Mamane wrote:
> grub-install fails with the following command error message:
> 
> /usr/sbin/grub-setup: warn: Your embedding area is unusually small.  core.img won't fit in it..
> /usr/sbin/grub-setup: error: embedding is not possible, but this is required when the root device is on a RAID array or LVM volume.
> 
> Leading me to think it will *not* successfully boot my system. But
> upgrade-from-grub-legacy still deleted grub1, it says:
> 
> GRUB Legacy has been removed, but its configuration files have been preserved,
> since this script cannot determine if they contain valuable information.  If
> you would like to remove the configuration files as well, use the following
> command:
> 
> and indeed I don't find the grub1 files in /boot/grub, except for
> menu.lst*.
> 
> So it has rendered my system unbootable, all because it ignores the
> "error" return code of grub-install:

Thanks, this is indeed pretty bad.  This is partly fixed (by spotting
the non-zero exit code and displaying a debconf question on failure) in
a set of changes I have in progress in order to fix #554790 et al, but
it needs to behave slightly differently in the middle of
upgrade-from-grub-legacy.  I'll make sure that this happens when I merge
that code.

-- 
Colin Watson                                       [cjwatson at debian.org]