Bug#586621: Regarding the proposed patch

M. Vefa Bicakci bicave at superonline.com
Sun Jul 4 14:26:12 UTC 2010


Hello Matt Kraai,

I noticed that you didn't move the "free(new_prefix)" line
to the end of the function. The net effect of not doing this
is that you might use the "new_prefix" pointer later even
though you "free()"d it before.

Attached is the patch which includes a fix for this problem.
It frees the new_prefix pointer at the end of the function
only if it is non-NULL.

I really appreciate the fact that you were able to find a
solution to the bug.

Regards,

M. Vefa Bicakci

-------------- next part --------------
A non-text attachment was scrubbed...
Name: copy-new_prefix-to-prefix.patch
Type: text/x-diff
Size: 1895 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20100704/2c9af721/attachment.patch>


More information about the Pkg-grub-devel mailing list