Bug#584812: grub-common: savedefault doesn't work anymore

[Colin Watson]

On Sun, Jun 06, 2010 at 09:49:44PM +0200, Mario 'BitKoenig' Holbe wrote:
> since a little while (probably since 1.98+20100602-1) grubs savedefault
> doesn't work anymore. On boot, always the first entry is selected and
> thus booted automatically no matter what entry was chosen before.
> 
> /boot/grub/grubenv always contains saved_entry=Debian instead of the
> complete menuentry name.
> 
> I attached a patch that protects all variable expansions against spaces
> and makes savedefault working again.

Thanks for this.  I'd already committed part of this upstream, since
Vladimir noticed it independently, but I missed a few bits.

prefix and root should never contain spaces, and I don't really want to
uglify the generated configuration file by quoting those.  Could you
please confirm that these parts of your diff are sufficient?

> -if [ ${prev_saved_entry} ]; then
> -  set saved_entry=${prev_saved_entry}
> +if [ "${prev_saved_entry}" ]; then
> +  set saved_entry="${prev_saved_entry}"

> -  if [ -z ${boot_once} ]; then
> -    saved_entry=${chosen}
> +  if [ -z "${boot_once}" ]; then
> +    saved_entry="${chosen}"

Cheers,

-- 
Colin Watson                                       [cjwatson at debian.org]