Bug#586358: grub-pc: Please handle DOS line endings in "cat"

Colin Watson cjwatson at ubuntu.com
Mon Jun 28 07:53:07 UTC 2010


On Mon, Jun 28, 2010 at 01:02:06AM +0100, Colin Watson wrote:
> On Fri, Jun 25, 2010 at 08:51:12PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > Colin Watson wrote:
> > > On Fri, Jun 18, 2010 at 11:34:08AM -0700, Josh Triplett wrote:
> > >> The "cat" command, if given a file with DOS line endings, will show the
> > >> \r at the end of every line as a control character.  For convenience,
> > >> please consider adding support for this in "cat", ideally automatically.
> > >
> > > Makes sense to me.  grub-devel, how about this patch?
> > 
> > Unconditionaly stripping \r is a bad idea because sometimes cat in grub
> > is used to determine why the system fails to boot. And if by a stupid
> > action fstab becomes DOS-formated 'cat /etc/fstab' will fail to show
> > this important point. But it's ok to add an option for cat'ing DOS
> > files.
> 
> OK.  How about the following patch, then?

Vladimir approved this on IRC.  Committed.

-- 
Colin Watson                                       [cjwatson at ubuntu.com]





More information about the Pkg-grub-devel mailing list