Bug#612417: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417)

[Alexander Kurtz]

Hi,

currently you can't use an image which has whitespace in its filename as
GRUB background image because grub-mkconfig_lib lacks proper variable
quoting (see [1] for more information). I've attached three patches
which should fix this problem:

 quote-big.patch:
  This patch fixes the problem with the minimal set of changes.

 quote-medium.patch:
  This patch adds proper quoting wherever it is safe to do so.

 quote-small.patch
  This patch additionally adds quoting in cases like this:
   ${grub-probe} --foo --bar => "${grub-probe}" --foo --bar
  This breaks things if ${grub-probe} contains additional parameters.

Please note that I already submitted similar patches a while ago[2], but
these are a little outdated now. The attached patches have been
refreshed and should apply cleanly to the current trunk.

What do you think?

Best regards

Alexander Kurtz

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612417#5
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612417#10
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quote-small.patch
Type: text/x-patch
Size: 770 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110405/a3bd5538/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quote-medium.patch
Type: text/x-patch
Size: 7070 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110405/a3bd5538/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quote-big.patch
Type: text/x-patch
Size: 7084 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110405/a3bd5538/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110405/a3bd5538/attachment.pgp>