Bug#608263: /etc/grub.d/05_debian_theme: new 05_debian_theme doesn't allow no background image

[Mario 'BitKoenig' Holbe]

Hello,

I guess I can avoid a new bugreport since this one matches somehow...

On Sun, Jan 02, 2011 at 05:17:05PM +0100, Alexander Kurtz wrote:
> Am Mittwoch, den 29.12.2010, 12:57 +0100 schrieb Miros??aw Zalewski:
> > There is brand new 05_debian_theme in newest grub-pc. Unfortunetly, it
> > does not allow user to have no background splash image at all, unless
> Yep, that's true. I'm currently thinking how the user could specify that
> he doesn't want a background image at all. Would it be ok, if you had to
> put a line like this into /etc/default/grub:
> 	GRUB_BACKGROUND=""

IMHO, 05_debian_theme should simply do nothing if GRUB_BACKGROUND is
set (empty or not), because this one is for and handled by 00_header
already (not as sophisticated as 05_debian_theme does it, but ...
well...).
Btw: testing for an empty but set environment variable is not that
easy... :) 'if env | grep -q ^GRUB_BACKGROUND=; then ...' comes to my
mind...

IMHO, the same applies for the case where 05_debian_theme chooses the
lexically first image in /boot/grub - just don't do it: if the user
copied one there, he had to configure it somewhere anyways.

Furthermore, the default colors set by 05_debian_theme for the three
alternatives to grub_background.sh: GRUB_BACKGROUND, the lexically first
image in /boot/grub, and for desktop-grub.png if no grub_background.sh
exists are simply ... well, useless: black/black - hmmm :)

Btw2: I guess, #581049 could be closed now where 05_debian_theme deals
with the desktop-grub alternative.


thanks for your work & regards
   Mario
-- 
You know, people think mathematics is complicated. Mathematics is the simple
bit. Its the stuff we can understand. Its cats that are complicated. I mean,
what is it in those little molecules and stuff that make one cat behave
differently than another, or that make a cat? And how do you define a cat?
I have no idea.                                 -- John Conway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110104/541caa88/attachment.pgp>