Bug#608283: 05_debian_theme: Allow override of text color

[Colin Watson]

On Sun, Jan 02, 2011 at 05:33:24PM +0100, Alexander Kurtz wrote:
> Am Mittwoch, den 29.12.2010, 18:05 +0100 schrieb Udo Richter:
> > With the changes of bug#605705, the background can be overwritten using
> > GRUB_BACKGROUND in /etc/default/grub, but changing the colors of the
> > menu is not possible. Depending on the background, the default colors
> > black/black and magenta/black might not be a good choice. My suggestion
> > is to also allow to override color_normal and color_highlight from
> > /etc/default/grub.
> 
> I think this is a valid request.
> 
> > The attached patch does this in a way that allows overriding in all use
> > cases, even with a default or theme background picture. It introduces
> > the GRUB_BACKGROUND_COLOR_NORMAL and GRUB_BACKGROUND_COLOR_HIGHLIGHT
> > overrides that can be set in /etc/default/grub.
> > 
> > An alternative would be to use the override only if GRUB_BACKGROUND is
> > set. In that case, the parameters should be added to the
> > set_background_image "${GRUB_BACKGROUND}" line at the end.
> 
> Yes, this seem to be the possibilities we have.
> 
> Colin, which alternative do you prefer (I'd take the first one) and how
> shall the configuration variables be called? Maybe GRUB already has some
> variables for this purpose?

The /etc/default/grub namespace is owned by upstream.  Since
GRUB_BACKGROUND is implemented in 00_header as well as 05_debian_theme,
I would recommend that you write a patch that changes 00_header to
honour those new variables (I'm fine with the first option), changes
grub-mkconfig to export them, and documents them in 'info grub', and
send that patch upstream.

Once the addition to the namespace has been agreed upstream, I'd be fine
with changes to 05_debian_theme that made additional use of it.

-- 
Colin Watson                                       [cjwatson at debian.org]