Bug#608263: /etc/grub.d/05_debian_theme: new 05_debian_theme doesn't allow no background image

[Mario 'BitKoenig' Holbe]

On Wed, Jan 05, 2011 at 02:32:47PM +0100, Alexander Kurtz wrote:
> Well, I think that 05_debian_theme should keep handling $GRUB_BACKGROUND
> at least for now because it
>  a) can handle upper case file extensions (like DC01234567.JPEG from 
>  b) can handle files which aren't directly readable by GRUB (for 
>  c) keeps /boot/grub/ clean by only having *one* cache file. It even

Hmmm, probably we have different opinions about the focus of
05_debian_theme?

What do you intend it to be for?

My personal opinion is: 05_debian_theme is Debian-specific, it is not
pushed upstream. Hence, it should handle the Debian-specific things, but
nothing more.

I know, 05_debian_theme is currently a very sophisticated variant of
GRUB's comparably basic background-handling and I honestly like the work
you did - especially the caching. I know it does some things better than
upstream. And, of course, I understand that you like to have this work
to be applied to the non-Debian-specific cases as well.  However, I
personally believe you implemented this the wrong way: If you
like to have upper case file extensions handled, if you like to have a
cute caching for files not directly readable by GRUB, if you like to
have a garbage collection in /boot/grub, why don't you report it
upstream? Why do you like to keep it Debian-specific?
I.e.: why do you put all this in 05_debian_theme instead of giving
upstream a chance to adopt it?

> > IMHO, the same applies for the case where 05_debian_theme chooses the
> > lexically first image in /boot/grub - just don't do it: if the user
> > copied one there, he had to configure it somewhere anyways.
> No, the whole point is that there is no extra configuration necessary,

But there was. You changed that.

> simply doing this
> 	sudo cp foo.jpeg /boot/grub/ && sudo update-grub
> should be enough. My intention was to
...
>  b) support what the user might have tried intuitively

Strange users who try copying things somewhere and expect anything to
happen :) ... "The wall needs to be painted. Hey, let's put a bucket of
color close to it, I guess this will do the trick."
But well - they must be strange, they use sudo :)=

scnr.

> It's all about the magic words "It Just Works???".

I understand all this. But why on Debian only?

scnr again: Why on Debian at all? Doesn't this look more Ubuntu-like? :)

> > Furthermore, the default colors set by 05_debian_theme for the three
> I've chosen those colors because
>  a) that's what the old 05_debian_theme did and I wanted to stick as 
>     close to that behavior as possible

Hmmmm, wait... no, you didn't :)
This color was *only* installed for the moreblue-orbit theme (and is
good for it) - which you remove from /boot/grub now :)

>  b) because they are usually sane - black font is readable almost always

There is no sane default: black isnt readable on dark backgrounds, white
isn't readable on light backgrounds, etc. If you don't agree with
upstreams defaults, ... well, u know :)

GRUB's default colors are btw. even terminal-specific (well, at least in
principle).


Mario
-- 
Tower: "Say fuelstate." Pilot: "Fuelstate."
Tower: "Say again." Pilot: "Again."
Tower: "Arghl, give me your fuel!" Pilot: "Sorry, need it by myself..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110105/5e67134f/attachment.pgp>