Bug#608263: /etc/grub.d/05_debian_theme: new 05_debian_theme doesn't allow no background image

[Colin Watson]

On Mon, Jan 17, 2011 at 02:00:10PM +0100, Alexander Kurtz wrote:
> Am Montag, den 17.01.2011, 12:26 +0000 schrieb Colin Watson:
> > On Wed, Jan 05, 2011 at 07:42:37PM +0100, Alexander Kurtz wrote:
> > >  b) I'm thinking about not setting any default background colors and
> > >     just using GRUB's defaults.
> > 
> > I was just bitten by the black/black nonsense myself, and was unable to
> > see anything useful until I typed 'set color_normal=white/black' blind.
> 
> As mentioned earlier[1] there are valid reasons for using 'black/black'.

There are certainly valid reasons for having black as the foreground
colour.  I don't agree that it makes sense to use black as the
foreground *and* background colour.  The black border around the image
is just a bug.  The menu entry being transparent seems essentially
coincidental to me (perhaps you can track down where this happens?), and
I don't think it's worth the risk of an unreadable boot loader (again,
this happened to me).

> And there are valid reasons against using these colors. This simply
> depends on the background image. I therefore agree with Mario's
> position[2] that we shouldn't set any background colors at all.

Likewise.

> > If I can be bitten by this, others definitely can!  I'm going to change
> > this to just use the defaults, as you suggest.
> 
> Have you read my last mail[3] with the proposed patch? What do you think
> of it?

I missed that due to the new thread, sorry.

Please use the portable [ ... ] && [ ... ] rather than [ ... -a ... ]
(I'll correct this locally).

This looks fine to me, and I'll merge it pretty much as-is for
experimental.  I'd like to minimise the code change for squeeze (I'm not
even sure that I can get another upload into squeeze now), but I can
take care of that.  I think I will reduce it to these parts:

 b) drops the possibly unnecessary (opinions???) default background 
    colors
 e) changes 05_debian_theme to not try the other alternatives when 
    $GRUB_BACKGROUND is set. This should close #608263.
    You can now simply add
      GRUB_BACKGROUND=""
    to /etc/default/grub if you don't want any background image.

Thanks,

-- 
Colin Watson                                       [cjwatson at debian.org]