Bug#741656: grub-common: grub-mkrescue lost its -J flag, d-i now FTBFS on kfreebsd-*

[Cyril Brulebois]

[ cc-ing debian-boot@ for information. ]

Cyril Brulebois <kibi at debian.org> (2014-03-15):
> Package: grub-common
> Version: 2.02~beta2-7
> Severity: serious
> File: /usr/bin/grub-mkrescue
> Tags: d-i
> Justification: triggers FTBFS
> 
> Hi,
> 
> so there are some grub-* packages used in debian-installer's build-deps,
> and grub-common is among them, since grub-mkrescue is used on kfreebsd-*.
> It apparently lost its -J flag, making debian-installer FTBFS on those
> architectures. Excerpt from a daily build log after 2014-03-10:
> | # Create the ISO with Joliet extensions, needed for win32-loader.ini
> | grub-mkrescue --output=./tmp/netboot-9/mini.iso ./tmp/netboot-9/cd_tree -J
> | grub-mkrescue: invalid option -- 'J'
> | Try 'grub-mkrescue --help' or 'grub-mkrescue --usage' for more information.
> | make[2]: *** [arch_miniiso] Error 64

That this option gets rejected isn't entirely surprising given we
previously had a pass-through for unknown options:

grub2-2.00/util/grub-mkrescue.in (shell script):
| # Check the arguments.
| while test $# -gt 0
| do
|     option=$1
|     shift
| 
|     case "$option" in
…
|     *)
|         source="${source} ${option} $@"; break ;;
|     esac
| done

while lastest upload has a version rewritten in C and rejecting unknown
options instead of passing them through:

grub2-2.02~beta2/util/grub-mkrescue.c:
| static struct argp_option options[] = {
…
|   {0, 0, 0, 0, 0, 0}
| };
| 
| argp_parser (int key, char *arg, struct argp_state *state)
| {
|   if (grub_install_parse (key, arg))
|     return 0;
|   switch (key)
|     {
…
|     default:
|       return ARGP_ERR_UNKNOWN;
|     }
| }

[BTW the tag for -7 isn't to be found in the git repository right now.]

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20140315/f8e1c384/attachment.sig>