Bug#775202: Add support for running a 64-bit Linux kernel on a 32-bit EFI

Colin Watson cjwatson at debian.org
Tue Jan 27 20:12:51 UTC 2015


On Mon, Jan 12, 2015 at 04:24:24PM +0000, Steve McIntyre wrote:
> On Mon, Jan 12, 2015 at 03:17:39PM +0000, Colin Watson wrote:
> >This all looks reasonable enough, but why not "return is_64_kernel () ?
> >64 : 32;" here?  Then you could simplify
> >grub_install_get_default_x86_platform to just conditionalise on "if
> >(read_platform_size () == 64)" and avoid duplication.
> 
> Could do, yes. I personally tend to shy away from ternary usage like
> that, but meh. :-)

I meant this as a rough sketch rather than literal code ...

> OK, how about:

Looks good, thanks!  Sorry for the delay in reviewing this.  I've pushed
it to the Debian master branch.

-- 
Colin Watson                                       [cjwatson at debian.org]



More information about the Pkg-grub-devel mailing list