Bug#741656: grub-common: grub-mkrescue lost its -J flag, d-i now FTBFS on kfreebsd-*

[Colin Watson]

On Sat, Nov 26, 2016 at 06:17:28AM +0100, Cyril Brulebois wrote:
> kfreebsd-* builds are now failing to build with:
> | # Create the ISO with Joliet extensions, needed for win32-loader.ini
> | # NOTE: "-- -J" is a workaround for #741656 in grub-common
> | grub-mkrescue --output=./tmp/netboot-10/mini.iso ./tmp/netboot-10/cd_tree -- -J
> | xorriso 1.4.6 : RockRidge filesystem manipulator, libburnia project.
> | 
> | xorriso : FAILURE : Not a known command:  '-J'
> | 
> | xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
> | install -m 644 -D ./tmp/netboot-10/mini.iso dest/netboot-10/mini.iso
> | install: cannot stat './tmp/netboot-10/mini.iso': No such file or directory
> | Makefile:798: recipe for target 'dest/netboot-10/mini.iso' failed
> 
> I think that started with grub2 (2.02~beta3-1) reaching unstable:
>   https://tracker.debian.org/news/805858
> 
> as upload timing would match the start of the FTBFS according to graphs
> on the summary page:
>   https://d-i.debian.org/daily-images/daily-build-overview.html
> 
> Also, util/grub-mkrescue.c's argument handling got changed between grub2
> 2.02~beta2-36 and 2.02~beta3-1.

Yep, as Thomas said, this changed back to the original state in
2.02~beta3.  I think that in fact allows us to close #741656 if you also
revert your previous workaround in d-i, but please confirm.  Compare:

  https://anonscm.debian.org/cgit/pkg-grub/grub.git/commit/?id=496cca85259c77b5fc8ad39a9064c83c3a39b7a6

(Sorry, I forgot that d-i had worked around this.)

-- 
Colin Watson                                       [cjwatson at debian.org]