Bug#842645: grub-common: GRUB_DISABLE_LINUX_UUID=true ignored in 10_linux and 20_linux_xen

[Daniel Reichelt]

Package: grub-common
Version: 2.02~beta3-1
Severity: important
Tags: patch

Hi,

in Stretch setting GRUB_DISABLE_LINUX_UUID=true in /etc/default/grub is
no longer respected during creation of linux menu entries.

The culprits are the checks in 10_linux:66-68 and 20_linux_xen:54:56
(identical in both scripts).

This was working fine until the new AND'ed check `uses_abstraction ...`
was added. This additional check actually requires a pair of hyphens to
have the desired effect with respect to operator precedence:

----------8<-----------------
if [ "x${GRUB_DEVICE_UUID}" = "x" ] || [ "x${GRUB_DISABLE_LINUX_UUID}" = "xtrue" ] \
    || ! test -e "/dev/disk/by-uuid/${GRUB_DEVICE_UUID}" \
    || (test -e "${GRUB_DEVICE}" && uses_abstraction "${GRUB_DEVICE}" lvm); then
---------->8-----------------



Cheers

Daniel



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.7.0-1-amd64 (SMP w/6 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: sysvinit (via /sbin/init)

Versions of packages grub-common depends on:
ii  gettext-base        0.19.8.1-1
ii  libc6               2.24-5
ii  libdevmapper1.02.1  2:1.02.133-1
ii  libfreetype6        2.6.3-3+b1
ii  libfuse2            2.9.7-1
ii  liblzma5            5.2.2-1.2

Versions of packages grub-common recommends:
pn  os-prober  <none>

Versions of packages grub-common suggests:
ii  console-setup  1.152
pn  desktop-base   <none>
pn  grub-emu       <none>
pn  multiboot-doc  <none>
pn  xorriso        <none>

-- no debconf information