Bug#912846: grub2: stop depending on ttf-dejavu-core

[Helmut Grohne]

Control: reassign -1 ttf-dejavu-core
Control: found -1 ttf-dejavu-core/2.37-1
Control: retitle -1 ttf-dejavu-core has a misleading package description

Hi Colin,

On Mon, Nov 05, 2018 at 12:22:11AM +0000, Colin Watson wrote:
> On Sun, Nov 04, 2018 at 03:57:50PM +0100, Helmut Grohne wrote:
> > grub2 Build-Depends on transitional dummy package ttf-dejavu-core. That
> > package is eventually slated for removal. Please update your dependency
> > to fonts-dejavu-core. ttf-dejavu-core happens to be unsatisfiable during
> > cross compilation. Patch attached.
> 
> > diff --minimal -Nru grub2-2.02+dfsg1/debian/control grub2-2.02+dfsg1/debian/control
> > --- grub2-2.02+dfsg1/debian/control	2018-10-29 13:36:47.000000000 +0100
> > +++ grub2-2.02+dfsg1/debian/control	2018-11-04 15:55:39.000000000 +0100
> > @@ -26,7 +26,7 @@
> >   cpio [i386 kopensolaris-i386 amd64 x32],
> >   parted [!hurd-any],
> >   libfuse-dev (>= 2.8.4-1.4) [linux-any kfreebsd-any],
> > - ttf-dejavu-core,
> > + fonts-dejavu-core,
> >   liblzma-dev,
> >   dosfstools [any-i386 any-amd64 any-arm64],
> >   mtools [any-i386 any-amd64 any-arm64],
> 
> I think this doesn't quite work because ttf-dejavu-core installs the
> relevant font file (DejaVuSans.ttf) to a different path, and it isn't
> one of those that configure.ac looks in; configure.ac will need to be
> patched to look in that path as well, and ideally that patch sent
> upstream first.

Thank you very much for catching my mistake. I was mislead by
ttf-dejavu-core's package description:

Description-en: transitional dummy package
 This package is a dummy transitional package. It can be safely removed.

I consider that a lie. The attached patch fixes the lie. It also marks
the transitional packages Multi-Arch: foreign, because that helps grub2
with cross compilation.

Helmut
-------------- next part --------------
diff --minimal -Nru fonts-dejavu-2.37/debian/changelog fonts-dejavu-2.37/debian/changelog
--- fonts-dejavu-2.37/debian/changelog	2016-08-16 20:18:06.000000000 +0200
+++ fonts-dejavu-2.37/debian/changelog	2018-11-05 05:30:21.000000000 +0100
@@ -1,3 +1,11 @@
+fonts-dejavu (2.37-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix descriptions of transitional packages. (Closes: #-1)
+  * Mark transitional packages Multi-Arch: foreign.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Mon, 05 Nov 2018 05:30:21 +0100
+
 fonts-dejavu (2.37-1) unstable; urgency=medium
 
   * Imported Upstream version 2.37.
diff --minimal -Nru fonts-dejavu-2.37/debian/control fonts-dejavu-2.37/debian/control
--- fonts-dejavu-2.37/debian/control	2016-08-16 20:15:26.000000000 +0200
+++ fonts-dejavu-2.37/debian/control	2018-11-05 05:30:19.000000000 +0100
@@ -127,33 +127,39 @@
  ttf-dejavu-extra,
  ${misc:Depends}
 Architecture: all
+Multi-Arch: foreign
 Section: oldlibs
 Priority: extra
 Pre-Depends:
  ${misc:Pre-Depends}
-Description: transitional dummy package
- This package is a dummy transitional package. It can be safely removed.
+Description: transitional package
+ This package is not a dummy transitional package. It contains symbolic links
+ providing the old locations of font files.
 
 Package: ttf-dejavu-core
 Depends:
  fonts-dejavu-core,
  ${misc:Depends}
 Architecture: all
+Multi-Arch: foreign
 Section: oldlibs
 Priority: extra
 Pre-Depends:
  ${misc:Pre-Depends}
-Description: transitional dummy package
- This package is a dummy transitional package. It can be safely removed.
+Description: transitional package
+ This package is not a dummy transitional package. It contains symbolic links
+ providing the old locations of font files.
 
 Package: ttf-dejavu-extra
 Depends:
  fonts-dejavu-extra,
  ${misc:Depends}
 Architecture: all
+Multi-Arch: foreign
 Section: oldlibs
 Priority: extra
 Pre-Depends:
  ${misc:Pre-Depends}
-Description: transitional dummy package
- This package is a dummy transitional package. It can be safely removed.
+Description: transitional package
+ This package is not a dummy transitional package. It contains symbolic links
+ providing the old locations of font files.