Bug#922104: grub-install: check for arm-efi as a default target

Colin Watson cjwatson at debian.org
Tue Feb 26 14:29:14 GMT 2019


On Tue, Feb 12, 2019 at 02:49:34AM +0000, Steve McIntyre wrote:
> I've already submitted the core of this upstream - see
> 
>   http://lists.gnu.org/archive/html/grub-devel/2019-02/msg00018.html
> 
> Much like on x86, we can work out if the system is running on top of
> EFI firmware. If so, return "arm-efi". If not, fall back to
> "arm-uboot" as previously.
> 
> Heavily inspired by the existing code for x86.
> 
> I'd push this as an MR, but my head is just not in the right place for
> handling git-dpm right now :-(
> 
> Here's a patch instead, ready to drop into debian/patches. I've
> extended the code here in similar fashion to what's already been added
> in our version of grub_install_get_default_x86_platform() to check in
> the pkglibdir. Otherwise this new code is just the same as I've sent
> upstream yesterday.

Thanks.  I'd prefer to have the upstream and pkglibdir parts as separate
patches, though, since that'll make rebasing onto new upstream releases
easier in future.

I cherry-picked the upstream patch (though noting that the version of
that isn't actually the same as the final version you posted to
grub-devel, so you might want to chase that up with Daniel), and applied
a separate patch on top of it to add the pkglibdir bits.

Cheers,

-- 
Colin Watson                                       [cjwatson at debian.org]



More information about the Pkg-grub-devel mailing list