Bug#953201: grub-common: grub-mkconfig should not exit 0 if ${grub_mkconfig_dir}/00_header is obsolete

Matthew Vernon mv3 at sanger.ac.uk
Thu Mar 5 17:23:16 GMT 2020


package: grub-common
version: 2.02-2

Hi,

grub-mkconfig (called by update-grub amongst others) has:

if fgrep -qs '${GRUB_PREFIX}/video.lst' 
"${grub_mkconfig_dir}/00_header"; then
   echo "GRUB >= 2.00 has been unpacked but not yet configured." >&2
   echo "grub-mkconfig will not work until the upgrade is complete." >&2
   echo "It should run later as part of configuring the new GRUB 
packages." >&2
   exit 0
fi

On upgrading a (very old) system, dpkg didn't over-write 
/etc/grub.d/00_header and instead created 00_header.dpkg-dist . The 
upgrade seemingly worked, but in fact the new bootloader didn't get 
installed.

I think this code should be removed, and grub-mkconfig should in fact 
error out in this case, rather than exiting 0.

Thanks,

Matthew


-- 
 The Wellcome Sanger Institute is operated by Genome Research 
 Limited, a charity registered in England with number 1021457 and a 
 company registered in England with number 2742969, whose registered 
 office is 215 Euston Road, London, NW1 2BE. 



More information about the Pkg-grub-devel mailing list