Bug#1020514: grub-efi-amd64: Package upgrade did not fail when /boot is full

[John-Mark Bell]

Package: grub-efi-amd64
Version: 2.06-3~deb11u1
Severity: normal
X-Debbugs-Cc: john-mark.bell at pexip.com

Dear Maintainer,

Upgrading from grub-efi-amd64 2.04-20 to 2.06-3~deb11u1 when the /boot
partition was full reported the following in the console logs:

Setting up grub-efi-amd64 (2.06-3~deb11u1) ...
Installing for x86_64-efi platform.
grub-install: error: cannot copy `/usr/lib/grub/x86_64-efi/bufio.mod' to `/boot/grub/x86_64-efi/bufio.mod': No space left on device.
Failed: grub-install --target=x86_64-efi  
WARNING: Bootloader is not properly installed, system may not be bootable
Generating grub configuration file ...
Found background image: .background_cache.png
Found linux image: /boot/vmlinuz-5.10.0-11-amd64
Found initrd image: /boot/initrd.img-5.10.0-11-amd64
Found linux image: /boot/vmlinuz-5.10.0-10-amd64
Found initrd image: /boot/initrd.img-5.10.0-10-amd64
Found linux image: /boot/vmlinuz-5.10.0-9-amd64
Found initrd image: /boot/initrd.img-5.10.0-9-amd64
Found linux image: /boot/vmlinuz-4.19.0-18-amd64
Found initrd image: /boot/initrd.img-4.19.0-18-amd64
Warning: os-prober will be executed to detect other bootable partitions.
Its output will be used to detect bootable binaries on them and create new boot entries.
Adding boot menu entry for UEFI Firmware Settings ...
done

The grub-install failure, did not, however, result in the package
installation being marked as failed, which may well have left the
system in an unbootable state had it been rebooted afterwards (as it
happens, I spotted this in the logs and rectified the situation manually).

I would have expected the failure to install the bootloader to be
treated as a package install failure (to ensure the administrator has
the opportunity to notice and resolve the problem before rebooting).

-- System Information:
Debian Release: 11.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-10-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_AUX
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages grub-efi-amd64 depends on:
ii  debconf [debconf-2.0]  1.5.77
ii  grub-common            2.06-3~deb11u1
ii  grub-efi-amd64-bin     2.06-3~deb11u1
ii  grub2-common           2.06-3~deb11u1
ii  ucf                    3.0043

grub-efi-amd64 recommends no packages.

grub-efi-amd64 suggests no packages.

-- debconf information excluded