Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Anthony Iliopoulos]

On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:
> Philip Hands <phil at hands.com> writes:
> 
> > Anthony Iliopoulos <ailiop at suse.com> writes:
> > ...
> >> Yeap it is due to nrext64, I've submitted a patch to grub (should have
> >> cc'ed linux-xfs..)
> >>
> >> https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/
> >
> > That certainly seems to fix this bug.
> 
> ... but sadly that may not be the end of the story.
> 
> I've persuaded D-I to use the patched grub version, and when testing it,
> it now gets past the previous failure to complete the install, but then
> fails to boot after the first reboot, as seen here:
> 
>   https://openqa.debian.net/tests/200160#step/_console_wait_login/7
> 
> where it drops to the 'grub rescue>' prompt, complaining that:
> 
>   error: file `/boot/grub/i386-pc/normal.mod' not found.
> 
> if one types `ls (hd0,msdos1)/boot/grub/i386-pc` at that rescue prompt,
> it lists the files up to msdospart.mod and then says:
> 
>   error: invalid XFS directory entry.
> 
> (BTW the directory seemed fine before the reboot, because I listed it)

This issue exists independently of the large extent counter, and it is
related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
fuzzing the XFS filesystem"). That's actually the issue described in
#1051543.

There's a proposed fix at [1], and it works as expected with that patch
applied.

Regards,
Anthony

[1] https://lore.kernel.org/grub-devel/20231018030347.36174-1-nuxi@vault24.org/