[Pkg-haskell-commits] darcs: tools: Pass flags first, it seems we are running out of command length limits

[Joachim Breitner]

Tue Dec  3 22:24:09 UTC 2013  Joachim Breitner <mail at joachim-breitner.de>
  * Pass flags first, it seems we are running out of command length limits

    M ./all-packages/test-packages.pl -5 +7

Tue Dec  3 22:24:09 UTC 2013  Joachim Breitner <mail at joachim-breitner.de>
  * Pass flags first, it seems we are running out of command length limits
diff -rN -u old-tools/all-packages/test-packages.pl new-tools/all-packages/test-packages.pl
--- old-tools/all-packages/test-packages.pl	2013-12-08 16:50:24.877417543 +0000
+++ new-tools/all-packages/test-packages.pl	2013-12-08 16:50:24.929417532 +0000
@@ -11,6 +11,7 @@
 use Text::Patch;
 use IPC::Run qw( run );
 use Getopt::Long;
+use List::MoreUtils qw(uniq);
 
 my %packages;
 my %versions;
@@ -196,7 +197,11 @@
 close CABAL;
 chmod 0444, "all-packages.cabal";
 
-my @params = ("cabal", "--config-file", "$sandboxdir/config", "install", "--dry-run", "--force-reinstall", "--enable-tests");
+my @params = ("cabal", "-v", "--config-file", "$sandboxdir/config", "install", "--dry-run", "--force-reinstall", "--enable-tests");
+
+ at flags = uniq(@flags);
+push @params, @flags;
+printf "Using flags: %s\n", join " ", @flags;
 
 for my $pkg (sort keys %versions) {
 	next if (exists $comments{$pkg});
@@ -207,15 +212,12 @@
 	next if (exists $notest{$pkg});
 	push @params, sprintf "%s", $pkg;
 }
-push @params, @flags;
-
-printf "Using flags: %s\n", join ", ", @flags;
 
 print "Running cabal-install...\n";
 my $out;
 my $err;
 if (run \@params, \"", \$out, \$err) {
-	my $count;
+	my $count=0;
 	while ($out =~ m!^([a-zA-H0-9-]+)-([0-9.]+)$!gm) {
 		my ($pkg, $version) = ($1, $2);
 		unless (exists $versions{$pkg}) {