[Pkg-haskell-maintainers] Bug#576447: haskell-devscripts: Haskell cleanup fails if optional hlibrary.setup is missing

[Jonas Smedegaard]

Package: haskell-devscripts
Version: 0.7.6
Severity: important

The clean rule contains the following:

  [ -x "$(DEB_SETUP_BIN_NAME)" ] && $(DEB_SETUP_BIN_NAME) clean

That is plain wrong, as it will then fail if the test fails.

The following (untested!) should work:

  [ ! -x "$(DEB_SETUP_BIN_NAME)" ] || $(DEB_SETUP_BIN_NAME) clean

For an example of what this affects, see here:
https://buildd.debian.org/fetch.cgi?pkg=pandoc&arch=i386&ver=1.5.1.1-1&stamp=1270352485&file=log

Kind regards,

 - Jonas


P.S.

My offer to adopt hlibrary.mk as part of cdbs still stands.  And I will
gladly help you get proper access so as to be able to speedily apply any
Haskell-specific changes.