[Pkg-haskell-maintainers] Bug#704817: haskell-testpack: fails to build with experimental ghc

[Colin Watson]

Package: haskell-testpack
Version: 2.1.1-1
Severity: normal
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch raring

haskell-testpack fails to build against experimental ghc as follows:

  [3 of 3] Compiling Test.HUnit.Tools ( src/Test/HUnit/Tools.hs, dist-ghc/build/Test/HUnit/Tools.o )
  
  src/Test/HUnit/Tools.hs:131:57:
      `maxDiscard' is not a (visible) constructor field name
  
  src/Test/HUnit/Tools.hs:177:40: Not in scope: `maxDiscard'
  make: *** [build-ghc-stamp] Error 1

There's been a patch for this in a github pull request for a while.  In
accordance with private comments made by the principal uploader, and
after checking on #debian-haskell a couple of days ago, I plan to upload
a 0-day NMU for this once I get a bug number back, as follows aside from
the bug number in the changelog.

diff -u haskell-testpack-2.1.1/debian/changelog haskell-testpack-2.1.1/debian/changelog
--- haskell-testpack-2.1.1/debian/changelog
+++ haskell-testpack-2.1.1/debian/changelog
@@ -1,3 +1,13 @@
+haskell-testpack (2.1.1-1.1) experimental; urgency=low
+
+  * Non-maintainer upload.
+  * Depend on haskell-devscripts 0.8.13 to ensure this package is built
+    against experimental.
+  * Apply https://github.com/jgoerzen/testpack/pull/7 to port to QuickCheck
+    2.5, which dropped the maxDiscard field.
+
+ -- Colin Watson <cjwatson at debian.org>  Sat, 06 Apr 2013 10:51:07 +0100
+
 haskell-testpack (2.1.1-1) unstable; urgency=low
 
   * [27449fc] Imported Upstream version 2.1.1
diff -u haskell-testpack-2.1.1/debian/control haskell-testpack-2.1.1/debian/control
--- haskell-testpack-2.1.1/debian/control
+++ haskell-testpack-2.1.1/debian/control
@@ -4,7 +4,7 @@
 Uploaders: John Goerzen <jgoerzen at complete.org>
 Build-Depends: cdbs,
                debhelper (>= 7),
-               haskell-devscripts (>= 0.8),
+               haskell-devscripts (>= 0.8.13),
                ghc,
                ghc-prof,
                libghc-mtl-dev,
only in patch2:
unchanged:
--- haskell-testpack-2.1.1.orig/src/Test/HUnit/Tools.hs
+++ haskell-testpack-2.1.1/src/Test/HUnit/Tools.hs
@@ -128,7 +128,7 @@
 >        q "Integer -> Int (safe bounds)" prop_integer_to_int_pass]
 -}
 qc2hu :: QC.Testable a => Int -> String -> a -> HU.Test
-qc2hu maxTest = qccheck (stdArgs {maxSuccess = maxTest, maxDiscard = 20000})
+qc2hu maxTest = qccheck (stdArgs {maxSuccess = maxTest})
 
 {- | Run verbose tests.  Example:
 
@@ -174,7 +174,7 @@
               Just (rnd,_) -> return rnd
      test MkState{ terminal          = tm
                  , maxSuccessTests   = maxSuccess args
-                 , maxDiscardedTests = maxDiscard args
+                 , maxDiscardedTests = 20000
                  , computeSize       = case replay args of
                                          Nothing    -> \n d -> (n * maxSize args)
                                                          `div` maxSuccess args

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]