Bug#872278: setResponseTimeout Nothing has silently changed behavior with http-client 0.5.0

[Joey Hess]

Package: libghc-dav-dev
Version: 1.3.1-2+b5
Severity: normal

Proir to http-client 0.5.0, setResponseTimeout Nothing disabled the
timeout entirely. However with http-client 0.5.0, setResponseTimeout Nothing
sets responseTimeout = responseTimeoutDefault, which is 30 seconds.

I want to entirely disable the timeout. I could use setResponseTimeout
(Just maxBound), and that would work ok on 64 bit; Int is large enough
that this would make the timeout years long. But on 32 bit, it would be
only a couple of minutes.

Please consider this patch to make the behavior consistent and allow
entirely disabling the timout again.

- setResponseTimeout rt = baseRequest %= \x -> x { responseTimeout = maybe responseTimeoutDefault responseTimeoutMicro rt }
+ setResponseTimeout rt = baseRequest %= \x -> x { responseTimeout = maybe responseTimeoutNone responseTimeoutMicro rt }

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libghc-dav-dev depends on:
ii  ghc [libghc-transformers-dev-0.5.2.0-1d020]                  8.0.2-5
ii  libc6                                                        2.24-14
pn  libghc-base-dev-4.9.1.0-d28d6                                <none>
pn  libghc-bytestring-dev-0.10.8.1-45b2c                         <none>
ii  libghc-case-insensitive-dev [libghc-case-insensitive-dev-1.  1.2.0.10-1+b1
pn  libghc-containers-dev-0.5.7.1-cd211                          <none>
ii  libghc-data-default-dev [libghc-data-default-dev-0.7.1.1-bf  0.7.1.1-2+b2
ii  libghc-exceptions-dev [libghc-exceptions-dev-0.8.3-5fa88]    0.8.3-4
ii  libghc-http-client-dev [libghc-http-client-dev-0.5.7.0-8bd7  0.5.7.0-1+b3
ii  libghc-http-client-tls-dev [libghc-http-client-tls-dev-0.3.  0.3.5.1-1+b3
ii  libghc-http-types-dev [libghc-http-types-dev-0.9.1-0f9fc]    0.9.1-3+b5
ii  libghc-lens-dev [libghc-lens-dev-4.15.1-54553]               4.15.1-1
ii  libghc-mtl-dev [libghc-mtl-dev-2.2.1-1a6c5]                  2.2.1-5+b1
ii  libghc-transformers-base-dev [libghc-transformers-base-dev-  0.4.4-6+b1
ii  libghc-transformers-compat-dev [libghc-transformers-compat-  0.5.1.4-2+b1
ii  libghc-utf8-string-dev [libghc-utf8-string-dev-1.0.1.1-9093  1.0.1.1-4+b2
ii  libghc-xml-conduit-dev [libghc-xml-conduit-dev-1.3.5-4eb5c]  1.3.5-3+b7
ii  libghc-xml-hamlet-dev [libghc-xml-hamlet-dev-0.4.1-b7697]    0.4.1-1+b3
ii  libgmp10                                                     2:6.1.2+dfsg-1
ii  zlib1g                                                       1:1.2.8.dfsg-5

libghc-dav-dev recommends no packages.

Versions of packages libghc-dav-dev suggests:
ii  libghc-dav-doc   1.3.1-2
pn  libghc-dav-prof  <none>

-- no debconf information

-- 
see shy jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-haskell-maintainers/attachments/20170815/0610631c/attachment.sig>