Bug#866375: cabal-debian does not generate shlibs:Depends for -utils pacakges

[Kei Hibino]

Package: cabal-debian
Version: 4.35.6-1+b1
Severity: important
Tags: patch

Dear Maintainer,

I made example sequence of cabal-debian like following.
`Depends:' block generated by cabal-debian which does not
contain `${shlibs:Depends}' variable.
So dependencies to shared object
which are linked by executables in haskell-*-utils packages
will be not generated.

-------
 % cabal unpack text-ldap-0.1.1.8
Unpacking to text-ldap-0.1.1.8/
 % cd text-ldap-0.1.1.8
 % cabal-debian
 % egrep -A 5 haskell-text-ldap-utils debian/control
Package: haskell-text-ldap-utils
Architecture: any
Section: misc
Depends: ${haskell:Depends},
 ${misc:Depends},
Recommends: ${haskell:Recommends},
-------

I made a small patch to fix this problem like following.

-------
--- cabal-debian-4.35.6.orig/src/Debian/Debianize/Finalize.hs
+++ cabal-debian-4.35.6/src/Debian/Debianize/Finalize.hs
@@ -411,6 +411,8 @@ binaryPackageRelations b typ = zoom A.de
     when (typ == B.Development) $ do
       B.depends %= (edds ++)
       B.depends %= (anyrel "${shlibs:Depends}" : )
+    when (typ == B.Utilities) $
+      B.depends %= (anyrel "${shlibs:Depends}" : )
     B.depends    %= ([anyrel "${haskell:Depends}", anyrel "${misc:Depends}"] ++)
     B.recommends %= (anyrel "${haskell:Recommends}" : )
     B.suggests   %= (anyrel "${haskell:Suggests}" :)
-------

This problem affects cabal-debian package in Debian stretch too.


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/40 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8), LANGUAGE=ja_JP:ja:en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages cabal-debian depends on:
ii  debhelper   10.5.1
ii  libbz2-1.0  1.0.6-8.1
ii  libc6       2.24-12
ii  libffi6     3.2.1-6
ii  libgmp10    2:6.1.2+dfsg-1
ii  zlib1g      1:1.2.8.dfsg-5

Versions of packages cabal-debian recommends:
ii  apt-file  3.1.4

cabal-debian suggests no packages.

-- no debconf information
-------------- next part --------------
--- cabal-debian-4.35.6.orig/src/Debian/Debianize/Finalize.hs
+++ cabal-debian-4.35.6/src/Debian/Debianize/Finalize.hs
@@ -411,6 +411,8 @@ binaryPackageRelations b typ = zoom A.de
     when (typ == B.Development) $ do
       B.depends %= (edds ++)
       B.depends %= (anyrel "${shlibs:Depends}" : )
+    when (typ == B.Utilities) $
+      B.depends %= (anyrel "${shlibs:Depends}" : )
     B.depends    %= ([anyrel "${haskell:Depends}", anyrel "${misc:Depends}"] ++)
     B.recommends %= (anyrel "${haskell:Recommends}" : )
     B.suggests   %= (anyrel "${haskell:Suggests}" :)