Bug#901012: haskell-wl-pprint-annotated: build with rtsopts=-N breaks s390x

[Mathieu Trudel-Lapierre]

Package: haskell-wl-pprint-annotated
Version: 0.1.0.0-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu cosmic ubuntu-patch

Dear Maintainer,

s390x build appears to break in s390x in Ubuntu, but also in Debian, and on
a few other arches in Debian (mips*, armel). Symptoms are tests breaking
because RTS does not recognize the -N option.

-N appears to not really be required for the tests to work correctly, so the
benefit of being able to run concurrently on multiple CPUs (from what I gather
is the point of -N) is limited on the architectures where it works, and clearly
breaks build on many other arches.

>From what I gather by looking into this, -N is generally not considered to be
a great default, so there seems to be no harm in disabling special rtsopts
handling. At the very leasts, tests are still run and appear to be passing
everywhere.


*** /tmp/tmp03NFJK/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/rtsopts_disable_N.patch: don't set --with-rtsopts=-N; it
    breaks tests on s390x and doesn't buy much elsewhere.


Thanks for considering the patch.


-- System Information:
Debian Release: buster/sid
  APT prefers cosmic
  APT policy: (500, 'cosmic')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-22-generic (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru haskell-wl-pprint-annotated-0.1.0.0/debian/patches/rtsopts_remove_N.patch haskell-wl-pprint-annotated-0.1.0.0/debian/patches/rtsopts_remove_N.patch
--- haskell-wl-pprint-annotated-0.1.0.0/debian/patches/rtsopts_remove_N.patch	1969-12-31 16:00:00.000000000 -0800
+++ haskell-wl-pprint-annotated-0.1.0.0/debian/patches/rtsopts_remove_N.patch	2018-06-07 17:15:31.000000000 -0700
@@ -0,0 +1,17 @@
+---
+ wl-pprint-annotated.cabal |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Index: b/wl-pprint-annotated.cabal
+===================================================================
+--- a/wl-pprint-annotated.cabal
++++ b/wl-pprint-annotated.cabal
+@@ -46,7 +46,7 @@ test-suite wl-pprint
+   hs-source-dirs:
+     test
+   default-extensions: FlexibleInstances TypeSynonymInstances DeriveFunctor DeriveFoldable DeriveTraversable DeriveGeneric DefaultSignatures
+-  ghc-options: -Wall -threaded -rtsopts -with-rtsopts=-N
++  ghc-options: -Wall -threaded
+   build-depends:
+     base       >= 4.8  && < 5,
+     containers >= 0.4  && < 0.6,
diff -Nru haskell-wl-pprint-annotated-0.1.0.0/debian/patches/series haskell-wl-pprint-annotated-0.1.0.0/debian/patches/series
--- haskell-wl-pprint-annotated-0.1.0.0/debian/patches/series	1969-12-31 16:00:00.000000000 -0800
+++ haskell-wl-pprint-annotated-0.1.0.0/debian/patches/series	2018-06-07 17:15:13.000000000 -0700
@@ -0,0 +1 @@
+rtsopts_remove_N.patch