Bug#958851: initramfs-tools: autopkgtest needs update for new version of shellcheck: SC2086: Double quote to prevent globbing and word splitting.

[Paul Gevers]

Source: initramfs-tools
Version: 0.136
Severity: serious
X-Debbugs-CC: debian-ci at lists.debian.org, shellcheck at packages.debian.org
Tags: sid bullseye
User: debian-ci at lists.debian.org
Usertags: needs-update
Control: affects -1 src:shellcheck

Dear maintainer(s),

With a recent upload of shellcheck the autopkgtest of initramfs-tools
fails in testing when that autopkgtest is run with the binary packages
of shellcheck from unstable. It passes when run with only packages from
testing. In tabular form:

                       pass            fail
shellcheck             from testing    0.7.1-1
initramfs-tools        from testing    0.136
all others             from testing    from testing

I copied some of the output at the bottom of this report.

Currently this regression is blocking the migration of shellcheck to
testing [1]. Of course, shellcheck shouldn't just break your autopkgtest
(or even worse, your package), but it seems to me that the change in
shellcheck was intended and your package needs to update to the new
situation.

If this is a real problem in your package (and not only in your
autopkgtest), the right binary package(s) from shellcheck should really
add a versioned Breaks on the unfixed version of (one of your)
package(s). Note: the Breaks is nice even if the issue is only in the
autopkgtest as it helps the migration software to figure out the right
versions to combine in the tests.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[1] https://qa.debian.org/excuses.php?package=shellcheck

https://ci.debian.net/data/autopkgtest/testing/amd64/i/initramfs-tools/5145819/log.gz

autopkgtest [21:50:34]: test shellcheck: [-----------------------

In /usr/share/initramfs-tools/init line 227:
	sleep $ROOTDELAY
              ^--------^ SC2086: Double quote to prevent globbing and
word splitting.

Did you mean:
	sleep "$ROOTDELAY"


In /usr/sbin/update-initramfs line 176:
		run-parts --arg=${version} --arg=${initramfs} \
                                ^--------^ SC2086: Double quote to
prevent globbing and word splitting.

Did you mean:
		run-parts --arg="${version}" --arg=${initramfs} \


In /usr/share/initramfs-tools/scripts/functions line 393:
		logsave -a -s $FSCK_LOGFILE fsck $spinner $force $fix -V -t "$TYPE" "$DEV"
                                                          ^----^ SC2086:
Double quote to prevent globbing and word splitting.

Did you mean:
		logsave -a -s $FSCK_LOGFILE fsck $spinner "$force" $fix -V -t "$TYPE"
"$DEV"


In /usr/share/initramfs-tools/scripts/functions line 398:
		logsave -a -s $FSCK_LOGFILE fsck $spinner $force $fix -T -t "$TYPE" "$DEV"
                                                          ^----^ SC2086:
Double quote to prevent globbing and word splitting.

Did you mean:
		logsave -a -s $FSCK_LOGFILE fsck $spinner "$force" $fix -T -t "$TYPE"
"$DEV"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent
globbing ...
autopkgtest [21:50:38]: test shellcheck: -----------------------]

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-haskell-maintainers/attachments/20200425/a231938e/attachment.sig>