Bug#992799: kdump-tools: please drop shellcheck autopkgtest

[Paul Gevers]

Source: kdump-tools
Version: 1:1.6.8.4
Severity: serious
X-Debbugs-CC: debian-ci at lists.debian.org, shellcheck at packages.debian.org
Tags: sid bookworm
User: debian-ci at lists.debian.org
Usertags: needs-update
Control: affects -1 src:shellcheck

Dear maintainer(s),

With a recent upload of shellcheck the autopkgtest of kdump-tools fails
in testing when that autopkgtest is run with the binary packages of
shellcheck from unstable. It passes when run with only packages from
testing. In tabular form:

                       pass            fail
shellcheck             from testing    0.7.2-2
kdump-tools            from testing    1:1.6.8.4
all others             from testing    from testing

I copied some of the output at the bottom of this report.

Currently this regression is blocking the migration of shellcheck to
testing [1]. Of course, shellcheck shouldn't just break your autopkgtest
(or even worse, your package), but in this case shellcheck just evolved.
Static analysis tools are intended to run on source code, while
autopkgtest is intended to run against installed packages, where source
code is in principle not relevant; we want to know whether the binary
packages, as provided in the Debian archive, work correctly. In our
opinion running this type of tools as integration tests in autopkgtest,
or even as build-time tests is Wrong™, and should not be done. (Having
them run in salsaci or equivalent is of course totally great.)

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[1] https://qa.debian.org/excuses.php?package=shellcheck

https://ci.debian.net/data/autopkgtest/testing/amd64/k/kdump-tools/14767452/log.gz

autopkgtest [02:17:15]: test shellcheck: [-----------------------

In /usr/sbin/kdump-config line 338:
	local sl_path="/sys/kernel/security/securelevel"
        ^-----------^ SC3043: In POSIX sh, 'local' is undefined.


In /usr/sbin/kdump-config line 354:
	local sb_path sb sm
        ^-----------------^ SC3043: In POSIX sh, 'local' is undefined.


In /usr/sbin/kdump-config line 1097:
	local sys_loaded="$sys_kexec_crash"
        ^--------------^ SC3043: In POSIX sh, 'local' is undefined.

For more information:
  https://www.shellcheck.net/wiki/SC3043 -- In POSIX sh, 'local' is
undefined.
autopkgtest [02:17:16]: test shellcheck: -----------------------]

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-haskell-maintainers/attachments/20210823/df20aa3e/attachment.sig>