Bug#1011913: haskell-swish: FTBFS: make: *** [/usr/share/cdbs/1/class/hlibrary.mk:153: build-ghc-stamp] Error 25

[Jonas Smedegaard]

Control: reassign -1 haskell-swish
Control: tag -1 pending

Quoting Scott Talbert (2022-05-29 03:48:43)
> On Sat, 28 May 2022, Jonas Smedegaard wrote:
> 
> > Control: reassign -1 haskell-devscripts
> > Control: retitle -1 haskell-devscripts: DEB_ENABLE_TESTS ignored
> > Control: affects -1 haskell-swish
> >
> > Quoting Lucas Nussbaum (2022-05-26 21:04:50)
> >> During a rebuild of all packages in sid, [haskell-swish] failed to build
> >> on amd64.
> > [...]
> >>> Running debian/hlibrary.setup test --builddir=dist-ghc --show-details=direct
> >>> Non-zero exit code 1.
> >>> hlibrary.setup: No test suites enabled. Did you remember to configure with
> >>> '--enable-tests'?
> >
> > haskell-swish built successfully when released in January, and contains
> > this in debian/rules:
> >
> >> DEB_ENABLE_TESTS = yes
> >
> > Perhaps this really is bug#1010179 and the "fix" only papered over the
> > underlying problem: @Scott, did you test packages _enabling_ tests or
> > only the default of having tests disabled?
> 
> Hi Jonas,
> 
> Actually, it looks like DEB_ENABLE_TESTS=yes had been broken in 
> haskell-devscripts for quite some time (even before Felix's changes).  If 
> you look at the January build log for haskell-swish, the tests were not 
> run at that time.  In the case of haskell-swish, DEB_ENABLE_TESTS needs to 
> be defined *before* including hlibrary.mk.  After fixing that, it seems 
> there are some missing test dependencies.

Oh!

This means haskell-swish hasn't ever run its tests since initial
packaging in 2013.  Thanks a lot for (indirectly) pointing that out to
me.

The missing build-dependencies was another bug in my rules file - a
silly missing comma in a macro call :-/

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-haskell-maintainers/attachments/20220529/2c6c7fd0/attachment.sig>