Bug#1120778: "cabal unpack foo" adds MSDOS/Windows carriage returns (^M)

[Nicholas D Steeves]

forwarded 1120778 https://github.com/haskell/hackage-server/issues/316
clone 1120778 -1
retitle -1 'dht upgrade foo' should merge Hackage's x-revision of foo.cabal
thanks

Scott Talbert, thank you for finding this!  I hope our Debian copy of
this bug will be enough to encourage them to deploy the sternenseemann's
fix.

Clint Adams <clint at debian.org> writes:

> I think what `cabal unpack` is doing is downloading https://hackage.haskell.org/package/hledger-ui-1.50.2/hledger-ui-1.50.2.tar.gz and then overwriting hledger-ui.cabal from the tarball (which has proper line endings) with https://hackage.haskell.org/package/hledger-ui-1.50.2/hledger-ui.cabal (which does not).

I think you're right, and it explains a bug I hadn't yet filed:

If you manually compare the hledger-interest.cabal generated by 'cabal
unpack' (downloads cabal file from Hackage and applies it on top) to the
hledger-interest.cabal of 'dht upgrade' (the cabal file in the release
tarball), the latter doesn't represent the state of hledger-interest on
Hackage.  In other words, the package-plan is consistent with Hackage,
but the Debian package (DHG_packages/p/foo) is not consistent with the
package-plan, nor with Hackage.  The addition of "x-revision" in the
updated cabal file header makes this easier to identify.

The work per-package-update that is currently required is thus: the
person who runs 'dht upgrade' reads Hackage's foo.cabal with their eyes
and brain and then manually creates a quilt series that replicates the
logical delta without importing Hackage's current CR/LF issue into the
Debian package at DHG_packages/p/foo.  Do I need to add more detail to
this newly cloned bug ('dht upgrade foo' should merge Hackage's
x-revision of foo.cabal)?

Cheers,
Nicholas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 857 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-haskell-maintainers/attachments/20251118/10bcbef1/attachment.sig>