[jenkins] 07/22: remove-findbugs
James Downing Page
jamespage at alioth.debian.org
Tue Aug 13 11:47:01 UTC 2013
This is an automated email from the git hooks/post-receive script.
jamespage pushed a commit to branch patch-queue/master
in repository jenkins.
commit 51dc711f2318823471c5dc544721f8711160613a
Author: Debian Java Maintainers <pkg-java-maintainers at lists.alioth.debian.org>
Date: Sun Aug 11 10:41:39 2013 +0100
remove-findbugs
Gbp-Pq-Topic: build
---
core/src/main/java/hudson/UDPBroadcastThread.java | 2 --
core/src/main/java/hudson/Util.java | 2 --
core/src/main/java/hudson/WebAppMain.java | 1 -
core/src/main/java/hudson/cli/GroovyshCommand.java | 2 --
core/src/main/java/hudson/logging/LogRecorderManager.java | 1 -
core/src/main/java/hudson/triggers/Trigger.java | 2 --
core/src/main/java/hudson/util/PluginServletFilter.java | 1 -
core/src/main/java/hudson/util/XStream2.java | 2 --
core/src/main/java/jenkins/model/Jenkins.java | 6 ------
core/src/main/java/jenkins/util/ProgressiveRendering.java | 1 -
core/src/test/java/hudson/slaves/ComputerLauncherTest.java | 2 --
core/src/test/java/hudson/tasks/junit/SuiteResultTest.java | 2 --
maven-plugin/src/main/java/hudson/maven/MavenUtil.java | 2 --
.../src/main/java/hudson/maven/reporters/SurefireArchiver.java | 1 -
14 files changed, 27 deletions(-)
diff --git a/core/src/main/java/hudson/UDPBroadcastThread.java b/core/src/main/java/hudson/UDPBroadcastThread.java
index 384321a..038a65e 100644
--- a/core/src/main/java/hudson/UDPBroadcastThread.java
+++ b/core/src/main/java/hudson/UDPBroadcastThread.java
@@ -23,7 +23,6 @@
*/
package hudson;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
import hudson.model.Hudson;
import jenkins.model.Jenkins;
import hudson.util.OneShotEvent;
@@ -69,7 +68,6 @@ public class UDPBroadcastThread extends Thread {
mcs = new MulticastSocket(PORT);
}
- @SuppressWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
@Override
public void run() {
try {
diff --git a/core/src/main/java/hudson/Util.java b/core/src/main/java/hudson/Util.java
index 9275e7f..29bb528 100644
--- a/core/src/main/java/hudson/Util.java
+++ b/core/src/main/java/hudson/Util.java
@@ -26,7 +26,6 @@ package hudson;
import com.sun.jna.Memory;
import com.sun.jna.Native;
import com.sun.jna.NativeLong;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
import hudson.Proc.LocalProc;
import hudson.model.TaskListener;
import hudson.os.PosixAPI;
@@ -356,7 +355,6 @@ public class Util {
return !fileInCanonicalParent.getCanonicalFile().equals( fileInCanonicalParent.getAbsoluteFile() );
}
- @SuppressWarnings("NP_BOOLEAN_RETURN_NULL")
private static Boolean isSymlinkJava7(File file) throws IOException {
try {
Object path = File.class.getMethod("toPath").invoke(file);
diff --git a/core/src/main/java/hudson/WebAppMain.java b/core/src/main/java/hudson/WebAppMain.java
index f73bbe0..cff39a0 100644
--- a/core/src/main/java/hudson/WebAppMain.java
+++ b/core/src/main/java/hudson/WebAppMain.java
@@ -248,7 +248,6 @@ public final class WebAppMain implements ServletContextListener {
/**
* Installs log handler to monitor all Hudson logs.
*/
- @edu.umd.cs.findbugs.annotations.SuppressWarnings("LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE")
private void installLogger() {
Jenkins.logRecords = handler.getView();
Logger.getLogger("").addHandler(handler);
diff --git a/core/src/main/java/hudson/cli/GroovyshCommand.java b/core/src/main/java/hudson/cli/GroovyshCommand.java
index ffd0b1d..5abc7b1 100644
--- a/core/src/main/java/hudson/cli/GroovyshCommand.java
+++ b/core/src/main/java/hudson/cli/GroovyshCommand.java
@@ -87,7 +87,6 @@ public class GroovyshCommand extends CLICommand {
private static final long serialVersionUID = 1L;
@SuppressWarnings("unused")
- @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS",justification="Closure invokes this via reflection")
public Object doCall(Object[] args) {
assert(args.length == 1);
assert(args[0] instanceof Shell);
@@ -110,7 +109,6 @@ public class GroovyshCommand extends CLICommand {
private static final long serialVersionUID = 1L;
@SuppressWarnings("unused")
- @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS",justification="Closure invokes this via reflection")
public Object doCall(Object[] args) throws ChannelClosedException {
if (args.length == 1 && args[0] instanceof ChannelClosedException) {
throw (ChannelClosedException)args[0];
diff --git a/core/src/main/java/hudson/logging/LogRecorderManager.java b/core/src/main/java/hudson/logging/LogRecorderManager.java
index f09a1c7..65896af 100644
--- a/core/src/main/java/hudson/logging/LogRecorderManager.java
+++ b/core/src/main/java/hudson/logging/LogRecorderManager.java
@@ -112,7 +112,6 @@ public class LogRecorderManager extends AbstractModelObject {
/**
* Configure the logging level.
*/
- @edu.umd.cs.findbugs.annotations.SuppressWarnings("LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE")
public HttpResponse doConfigLogger(@QueryParameter String name, @QueryParameter String level) {
Jenkins.getInstance().checkPermission(Jenkins.ADMINISTER);
Level lv;
diff --git a/core/src/main/java/hudson/triggers/Trigger.java b/core/src/main/java/hudson/triggers/Trigger.java
index e6714ca..372ae89 100644
--- a/core/src/main/java/hudson/triggers/Trigger.java
+++ b/core/src/main/java/hudson/triggers/Trigger.java
@@ -63,7 +63,6 @@ import java.util.logging.Logger;
import antlr.ANTLRException;
import javax.annotation.CheckForNull;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
/**
* Triggers a {@link Build}.
@@ -280,7 +279,6 @@ public abstract class Trigger<J extends Item> implements Describable<Trigger<?>>
*
* If plugins want to run periodic jobs, they should implement {@link PeriodicWork}.
*/
- @SuppressWarnings("MS_SHOULD_BE_FINAL")
public static @CheckForNull Timer timer;
@Initializer(after=JOB_LOADED)
diff --git a/core/src/main/java/hudson/util/PluginServletFilter.java b/core/src/main/java/hudson/util/PluginServletFilter.java
index 0decb8f..946cb43 100644
--- a/core/src/main/java/hudson/util/PluginServletFilter.java
+++ b/core/src/main/java/hudson/util/PluginServletFilter.java
@@ -58,7 +58,6 @@ public class PluginServletFilter implements Filter, ExtensionPoint {
public PluginServletFilter() {
}
- @edu.umd.cs.findbugs.annotations.SuppressWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
public void init(FilterConfig filterConfig) throws ServletException {
PluginServletFilter.filterConfig = filterConfig;
synchronized (LIST) {
diff --git a/core/src/main/java/hudson/util/XStream2.java b/core/src/main/java/hudson/util/XStream2.java
index c454397..134e660 100644
--- a/core/src/main/java/hudson/util/XStream2.java
+++ b/core/src/main/java/hudson/util/XStream2.java
@@ -41,7 +41,6 @@ import com.thoughtworks.xstream.io.HierarchicalStreamDriver;
import com.thoughtworks.xstream.io.HierarchicalStreamReader;
import com.thoughtworks.xstream.io.HierarchicalStreamWriter;
import com.thoughtworks.xstream.mapper.CannotResolveClassException;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
import hudson.PluginManager;
import hudson.PluginWrapper;
import hudson.diagnosis.OldDataMonitor;
@@ -388,7 +387,6 @@ public class XStream2 extends XStream {
private PluginManager pm;
- @SuppressWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE") // classOwnership checked for null so why does FB complain?
@Override public String ownerOf(Class<?> clazz) {
if (classOwnership != null) {
return classOwnership.ownerOf(clazz);
diff --git a/core/src/main/java/jenkins/model/Jenkins.java b/core/src/main/java/jenkins/model/Jenkins.java
index 7816b24..59ceb9e 100755
--- a/core/src/main/java/jenkins/model/Jenkins.java
+++ b/core/src/main/java/jenkins/model/Jenkins.java
@@ -730,10 +730,6 @@ public class Jenkins extends AbstractCIBase implements ModifiableTopLevelItemGro
* @param pluginManager
* If non-null, use existing plugin manager. create a new one.
*/
- @edu.umd.cs.findbugs.annotations.SuppressWarnings({
- "SC_START_IN_CTOR", // bug in FindBugs. It flags UDPBroadcastThread.start() call but that's for another class
- "ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" // Trigger.timer
- })
protected Jenkins(File root, ServletContext context, PluginManager pluginManager) throws IOException, InterruptedException, ReactorException {
long start = System.currentTimeMillis();
@@ -2642,7 +2638,6 @@ public class Jenkins extends AbstractCIBase implements ModifiableTopLevelItemGro
/**
* Called to shut down the system.
*/
- @edu.umd.cs.findbugs.annotations.SuppressWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
public void cleanUp() {
for (ItemListener l : ItemListener.all())
l.onBeforeShutdown();
@@ -3084,7 +3079,6 @@ public class Jenkins extends AbstractCIBase implements ModifiableTopLevelItemGro
/**
* For debugging. Expose URL to perform GC.
*/
- @edu.umd.cs.findbugs.annotations.SuppressWarnings("DM_GC")
public void doGc(StaplerResponse rsp) throws IOException {
checkPermission(Jenkins.ADMINISTER);
System.gc();
diff --git a/core/src/main/java/jenkins/util/ProgressiveRendering.java b/core/src/main/java/jenkins/util/ProgressiveRendering.java
index c13932e..6be3a13 100644
--- a/core/src/main/java/jenkins/util/ProgressiveRendering.java
+++ b/core/src/main/java/jenkins/util/ProgressiveRendering.java
@@ -24,7 +24,6 @@
package jenkins.util;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
import hudson.model.Computer;
import java.util.concurrent.ExecutorService;
import java.util.logging.Level;
diff --git a/core/src/test/java/hudson/slaves/ComputerLauncherTest.java b/core/src/test/java/hudson/slaves/ComputerLauncherTest.java
index 2ce563c..8c45ebf 100644
--- a/core/src/test/java/hudson/slaves/ComputerLauncherTest.java
+++ b/core/src/test/java/hudson/slaves/ComputerLauncherTest.java
@@ -24,7 +24,6 @@
package hudson.slaves;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
import java.io.BufferedReader;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
@@ -34,7 +33,6 @@ import org.apache.commons.io.output.NullOutputStream;
import org.junit.Test;
import static org.junit.Assert.*;
- at SuppressWarnings("DM_DEFAULT_ENCODING")
public class ComputerLauncherTest {
@Test public void jdk7() throws IOException {
diff --git a/core/src/test/java/hudson/tasks/junit/SuiteResultTest.java b/core/src/test/java/hudson/tasks/junit/SuiteResultTest.java
index ffeb8a0..02ecbeb 100644
--- a/core/src/test/java/hudson/tasks/junit/SuiteResultTest.java
+++ b/core/src/test/java/hudson/tasks/junit/SuiteResultTest.java
@@ -23,7 +23,6 @@
*/
package hudson.tasks.junit;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
import java.io.File;
import java.util.List;
import java.net.URISyntaxException;
@@ -178,7 +177,6 @@ public class SuiteResultTest extends TestCase {
}
}
- @SuppressWarnings({"RV_RETURN_VALUE_IGNORED_BAD_PRACTICE", "DM_DEFAULT_ENCODING", "OS_OPEN_STREAM"})
public void testSuiteStdioTrimmingSurefire() throws Exception {
File data = File.createTempFile("TEST-", ".xml");
try {
diff --git a/maven-plugin/src/main/java/hudson/maven/MavenUtil.java b/maven-plugin/src/main/java/hudson/maven/MavenUtil.java
index 5fb2297..225c765 100755
--- a/maven-plugin/src/main/java/hudson/maven/MavenUtil.java
+++ b/maven-plugin/src/main/java/hudson/maven/MavenUtil.java
@@ -54,7 +54,6 @@ import org.apache.maven.artifact.versioning.ComparableVersion;
import org.apache.maven.project.MavenProject;
import org.apache.maven.project.ProjectBuildingException;
-import edu.umd.cs.findbugs.annotations.SuppressWarnings;
/**
* @author Kohsuke Kawaguchi
@@ -142,7 +141,6 @@ public class MavenUtil {
* Creates a fresh {@link MavenEmbedder} instance.
*
*/
- @SuppressWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
public static MavenEmbedder createEmbedder(MavenEmbedderRequest mavenEmbedderRequest) throws MavenEmbedderException, IOException {
diff --git a/maven-plugin/src/main/java/hudson/maven/reporters/SurefireArchiver.java b/maven-plugin/src/main/java/hudson/maven/reporters/SurefireArchiver.java
index 52c8cf7..62532ef 100644
--- a/maven-plugin/src/main/java/hudson/maven/reporters/SurefireArchiver.java
+++ b/maven-plugin/src/main/java/hudson/maven/reporters/SurefireArchiver.java
@@ -199,7 +199,6 @@ public class SurefireArchiver extends TestFailureDetector {
return true;
}
- @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD", justification="It's okay to write to static fields here, as each Maven build is started in its own VM")
private void markBuildAsSuccess(Throwable mojoError, MavenBuildInformation buildInfo) {
if(mojoError == null // in the success case we don't get any exception in Maven 3.0.2+; Maven < 3.0.2 returns no exception anyway
|| mojoError instanceof MojoFailureException) {
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-java/jenkins.git
More information about the pkg-java-commits
mailing list