[libcommons-jexl2-java] 08/18: Improved the patch fixing the test failure

[Emmanuel Bourg]

This is an automated email from the git hooks/post-receive script.

ebourg-guest pushed a commit to branch master
in repository libcommons-jexl2-java.

commit 463d4c6996c4ccc96238513eff5f2b5c0bf8ce74
Author: Emmanuel Bourg <ebourg at apache.org>
Date:   Fri May 31 21:33:24 2013 +0000

    Improved the patch fixing the test failure
---
 debian/patches/001-Fix-tests.patch | 38 +++++++++++++++-----------------------
 1 file changed, 15 insertions(+), 23 deletions(-)

diff --git a/debian/patches/001-Fix-tests.patch b/debian/patches/001-Fix-tests.patch
index 469a742..c1f72d7 100644
--- a/debian/patches/001-Fix-tests.patch
+++ b/debian/patches/001-Fix-tests.patch
@@ -1,29 +1,21 @@
-Description: Disable the tests failing with JUnit 4.11 but not with the previous versions
+Description: Fix a test failure with JUnit 4.11 due to the out of order
+ execution of the test methods. This issue is fixed in JEXL 3.
 Author: Emmanuel Bourg
 Forwarded: not-needed
 --- a/src/test/java/org/apache/commons/jexl2/ArithmeticTest.java
 +++ b/src/test/java/org/apache/commons/jexl2/ArithmeticTest.java
-@@ -165,16 +165,8 @@
-         asserter.assertExpression("6 / 3", new Integer(6 / 3));
-         asserter.assertExpression("6.4 / 3", new Double(6.4 / 3));
-         asserter.assertExpression("0 / 3", new Integer(0 / 3));
--        asserter.assertExpression("3 / 0", new Double(0));
-         asserter.assertExpression("4 % 3", new Integer(1));
-         asserter.assertExpression("4.8 % 3", new Double(4.8 % 3));
--
--        /*
--         * test new null coersion
--         */
--        asserter.setVariable("imanull", null);
--        asserter.assertExpression("imanull + 2", new Integer(2));
--        asserter.assertExpression("imanull + imanull", new Integer(0));
-     }
- 
-     public void testCoercions() throws Exception {
-@@ -347,4 +339,4 @@
-         }
-         debuggerCheck(jexl);
-     }
+@@ -137,6 +137,7 @@
+      * test some simple mathematical calculations
+      */
+     public void testCalculations() throws Exception {
++        JexlThreadedArithmetic.setLenient(Boolean.TRUE);
+ 
+         asserter.setVariable("foo", new Integer(2));
+ 
+@@ -347,4 +348,4 @@
+         }
+         debuggerCheck(jexl);
+     }
 -}
 \ No newline at end of file
-+}
++}

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-java/libcommons-jexl2-java.git