[libpostgresql-jdbc-java] 09/14: Don't return quotes around identifiers in the results of DatabaseMetaData.getIndexInfo even if they would require quoting in SQL. The code was making a "col = NULL" comparison which doesn't work.

[Emmanuel Bourg]

This is an automated email from the git hooks/post-receive script.

ebourg-guest pushed a commit to tag REL8_2_506
in repository libpostgresql-jdbc-java.

commit b2b5f52edcd7a2ef68c1c3b121139903fefef357
Author: Kris Jurka <books at ejurka.com>
Date:   Mon Jul 23 17:30:46 2007 +0000

    Don't return quotes around identifiers in the results of
    DatabaseMetaData.getIndexInfo even if they would require quoting
    in SQL.  The code was making a "col = NULL" comparison which doesn't
    work.
    
    Reported by Andrei Badea.
---
 org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java b/org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java
index 5262bc3..b530e43 100644
--- a/org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java
+++ b/org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java
@@ -3,7 +3,7 @@
 * Copyright (c) 2004-2005, PostgreSQL Global Development Group
 *
 * IDENTIFICATION
-*   $PostgreSQL: pgjdbc/org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java,v 1.33.2.1 2007/04/11 07:33:26 jurka Exp $
+*   $PostgreSQL: pgjdbc/org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java,v 1.33.2.2 2007/07/15 15:10:13 jurka Exp $
 *
 *-------------------------------------------------------------------------
 */
@@ -3710,7 +3710,7 @@ public abstract class AbstractJdbc2DatabaseMetaData
 
         if( connection.haveMinimumServerVersion("7.4"))
         {
-            sql += " CASE i.indexprs WHEN null THEN a.attname ELSE pg_get_indexdef(ci.oid,a.attnum,false) END AS COLUMN_NAME, ";
+            sql += " CASE WHEN i.indexprs IS NULL THEN a.attname ELSE pg_get_indexdef(ci.oid,a.attnum,false) END AS COLUMN_NAME, ";
         }
         else
         {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-java/libpostgresql-jdbc-java.git