Review of patch from joshk

Reinhard Tartler siretart@tauware.de
Fri Jan 21 06:01:23 2005


Hi,

I just had a look at the proposed patch for java-package 0.18 of joshk.
It think it is very good work and should be uploaded to unstable soon.
Thank you for your work!

One remark/suggestion: This newer Version of java-package wont produce
deb files depending on these *debian helper packages. In fact, since
they are no longer created by java-package source package, they should
be removed as soon as an updated Java Debian package (created by
java-package) is installed.

To achieve this, I suggest that the created packages introduce a
Conflics and Replaces field for the corresponding, "obsolete" *debian
Package.

Jeroen suggested added a "provides" field. If I did understand things
correctly, the obsolete packages would not be removed then. If the user
would remove them afterwards, their postrm would remove the
alternatives. So I think the obsoleted packages must be removed before.

regards,
	Reinhard,