Bug#346224: marked as done (eclipse-platform-common: eclipse starter script will not set JAVA_HOME found from /etc/eclipse/java_home)

Debian Bug Tracking System owner at bugs.debian.org
Sat Jan 7 14:33:31 UTC 2006 

Your message dated Sat, 07 Jan 2006 06:17:16 -0800
with message-id <E1EvEse-0000bd-GT at spohr.debian.org>
and subject line Bug#346224: fixed in eclipse 3.1.1-8
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Jan 2006 14:46:08 +0000
>From tom at treizh.net Fri Jan 06 06:46:08 2006
Return-path: <tom at treizh.net>
Received: from smtp3.wanadoo.fr ([193.252.22.28])
	by spohr.debian.org with esmtp (Exim 4.50)
	id 1Eusr2-0007Fn-Fn
	for submit at bugs.debian.org; Fri, 06 Jan 2006 06:46:08 -0800
Received: from me-wanadoo.net (localhost [127.0.0.1])
	by mwinf0304.wanadoo.fr (SMTP Server) with ESMTP id 13FEA1C00C77
	for <submit at bugs.debian.org>; Fri,  6 Jan 2006 15:45:37 +0100 (CET)
Received: from home.treizh.net (ARennes-252-1-77-206.w86-195.abo.wanadoo.fr [86.195.224.206])
	by mwinf0304.wanadoo.fr (SMTP Server) with ESMTP id EC0961C00CCE
	for <submit at bugs.debian.org>; Fri,  6 Jan 2006 15:45:36 +0100 (CET)
X-ME-UUID: 20060106144536967.EC0961C00CCE at mwinf0304.wanadoo.fr
Received: by home.treizh.net (Postfix, from userid 33)
	id 08DCB311BA; Fri,  6 Jan 2006 15:45:31 +0100 (CET)
Received: from machine107.rd.francetelecom.com (machine107.rd.francetelecom.com [193.49.124.107]) 
	by webmail.treizh.net (IMP) with HTTP 
	for <thomas at localhost>; Fri, 06 Jan 2006 15:45:31 +0100
Message-ID: <1136558731.43be828bd0847 at webmail.treizh.net>
Date: Fri, 06 Jan 2006 15:45:31 +0100
From: Thomas Morin <tom at treizh.net>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: eclipse-platform-common: eclipse starter script will not set JAVA_HOME found from /etc/eclipse/java_home
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
User-Agent: Internet Messaging Program (IMP) 3.2.8
X-WebMail: ORUgooDnU
Content-Transfer-Encoding: quoted-printable
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	RCVD_IN_SORBS autolearn=no version=2.60-bugs.debian.org_2005_01_02

Package: eclipse-platform-common
Version: 3.1.1-7
Severity: normal
Tags: patch

There is a small bug in eclipse starter script : "export JAVA_HOME" is
done inside a "while" loop. But shell is tricky: the while actually creat=
es
a subprocess, so since the export is done there, it doesn't impact the
rest of the script. Thus JAVA_HOME will remain unset.

Result is this (if JAVA_HOME is not set elsewhere):
+ '[' -z '' ']'
+ echo 'searching for compatible vm...'
searching for compatible vm...
+ cat /etc/eclipse/java_home
+ grep -v '^#'
+ grep -v '^$'
+ read JAVA_HOME
+ echo -n '  testing /usr/lib/j2sdk1.5-sun...'
  testing /usr/lib/j2sdk1.5-sun...+ '[' -x
/usr/lib/j2sdk1.5-sun/bin/java ']'
+ export JAVA_HOME
+ echo found
found
+ break

# If we don't have a JAVA_HOME yet, we're doomed.
if [ -z "${JAVA_HOME}" ]; then
    zenity \
        --error \
        --title=3D"Could not launch Eclipse Platform" \
        --text=3D"A suitable Java Virtual Machine for running the Eclipse
Platform could not be located."
    exit 1
fi
+ '[' -z '' ']'
+ zenity --error '--title=3DCould not launch Eclipse Platform' '--text=3D=
A
suitable Java Virtual Machine for running the Eclipse Platform could not
be located.'
+ exit 1



A simple fix is to replace the 'while' loop by a 'for' loop:

--- /usr/bin/eclipse.orig       2006-01-06 15:31:34.000000000 +0100
+++ /usr/bin/eclipse    2006-01-06 15:32:19.000000000 +0100
@@ -65,8 +65,8 @@
 # and pick the first one that exists.
 if [ -z "${JAVA_HOME}" ]; then
     echo "searching for compatible vm..."
-    cat /etc/eclipse/java_home | grep -v '^#' | grep -v '^$' | \
-    while read JAVA_HOME; do
+    for JAVA_HOME in $(cat /etc/eclipse/java_home | grep -v '^#' | grep
-v '^$' );
+    do
         echo -n "  testing ${JAVA_HOME}..."
         if [ -x "${JAVA_HOME}/bin/java" ]; then
             export JAVA_HOME

(This won't work if some path contain a space)


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-nitro2
Locale: LANG=3Dfr_FR at euro, LC_CTYPE=3Dfr_FR at euro (charmap=3DISO-8859-15)

Versions of packages eclipse-platform-common depends on:
ii  gij-4.0 [java1-runtime]   4.0.2-6        The GNU Java bytecode interp=
reter
ii  java-common               0.23           Base of all Java packages
ii  java-gcj-compat           1.0.47-1       Java runtime environment usi=
ng
GIJ
ii  sun-j2sdk1.5 [java-common 1.5.0+update05 Java(TM) 2 SDK, Standard Edi=
tion,
ii  zenity                    2.12.1-1       Display graphical dialog box=
es
fro

eclipse-platform-common recommends no packages.

-- no debconf information



---------------------------------------
Received: (at 346224-close) by bugs.debian.org; 7 Jan 2006 14:21:54 +0000
>From katie at ftp-master.debian.org Sat Jan 07 06:21:54 2006
Return-path: <katie at ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
	id 1EvEse-0000bd-GT; Sat, 07 Jan 2006 06:17:16 -0800
From: Michael Koch <konqueror at gmx.de>
To: 346224-close at bugs.debian.org
X-Katie: $Revision: 1.65 $
Subject: Bug#346224: fixed in eclipse 3.1.1-8
Message-Id: <E1EvEse-0000bd-GT at spohr.debian.org>
Sender: Archive Administrator <katie at ftp-master.debian.org>
Date: Sat, 07 Jan 2006 06:17:16 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 5

Source: eclipse
Source-Version: 3.1.1-8

We believe that the bug you reported is fixed in the latest version of
eclipse, which is due to be installed in the Debian FTP archive:

eclipse-ecj-gcj_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-ecj-gcj_3.1.1-8_i386.deb
eclipse-ecj_3.1.1-8_all.deb
  to pool/main/e/eclipse/eclipse-ecj_3.1.1-8_all.deb
eclipse-efj_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-efj_3.1.1-8_i386.deb
eclipse-jdt-common_3.1.1-8_all.deb
  to pool/main/e/eclipse/eclipse-jdt-common_3.1.1-8_all.deb
eclipse-jdt-gcj_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-jdt-gcj_3.1.1-8_i386.deb
eclipse-jdt_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-jdt_3.1.1-8_i386.deb
eclipse-pde-common_3.1.1-8_all.deb
  to pool/main/e/eclipse/eclipse-pde-common_3.1.1-8_all.deb
eclipse-pde-gcj_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-pde-gcj_3.1.1-8_i386.deb
eclipse-pde_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-pde_3.1.1-8_i386.deb
eclipse-platform-common_3.1.1-8_all.deb
  to pool/main/e/eclipse/eclipse-platform-common_3.1.1-8_all.deb
eclipse-platform-gcj_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-platform-gcj_3.1.1-8_i386.deb
eclipse-platform_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-platform_3.1.1-8_i386.deb
eclipse-rcp-common_3.1.1-8_all.deb
  to pool/main/e/eclipse/eclipse-rcp-common_3.1.1-8_all.deb
eclipse-rcp-gcj_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-rcp-gcj_3.1.1-8_i386.deb
eclipse-rcp_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-rcp_3.1.1-8_i386.deb
eclipse-sdk_3.1.1-8_all.deb
  to pool/main/e/eclipse/eclipse-sdk_3.1.1-8_all.deb
eclipse-source_3.1.1-8_i386.deb
  to pool/main/e/eclipse/eclipse-source_3.1.1-8_i386.deb
eclipse_3.1.1-8.diff.gz
  to pool/main/e/eclipse/eclipse_3.1.1-8.diff.gz
eclipse_3.1.1-8.dsc
  to pool/main/e/eclipse/eclipse_3.1.1-8.dsc
eclipse_3.1.1-8_all.deb
  to pool/main/e/eclipse/eclipse_3.1.1-8_all.deb
libswt3.1-gtk-java_3.1.1-8_i386.deb
  to pool/main/e/eclipse/libswt3.1-gtk-java_3.1.1-8_i386.deb
libswt3.1-gtk-jni_3.1.1-8_i386.deb
  to pool/main/e/eclipse/libswt3.1-gtk-jni_3.1.1-8_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 346224 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Koch <konqueror at gmx.de> (supplier of updated eclipse package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat,  7 Jan 2006 11:45:19 +0000
Source: eclipse
Binary: eclipse-rcp-common eclipse-jdt-common eclipse-platform-gcj eclipse-source libswt3.1-gtk-jni libswt3.1-gtk-java eclipse-efj eclipse-pde-gcj eclipse-ecj-gcj eclipse-jdt eclipse-ecj eclipse-platform eclipse-sdk eclipse-jdt-gcj eclipse eclipse-pde eclipse-pde-common eclipse-rcp-gcj eclipse-rcp eclipse-platform-common
Architecture: source i386 all
Version: 3.1.1-8
Distribution: unstable
Urgency: low
Maintainer: Debian Java Maintainers <pkg-java-maintainers at lists.alioth.debian.org>
Changed-By: Michael Koch <konqueror at gmx.de>
Description: 
 eclipse    - Extensible Tool Platform and Java IDE
 eclipse-ecj - Eclipse Java compiler and Ant plug-in
 eclipse-ecj-gcj - Native version of the Eclipse Java compiler
 eclipse-efj - Eclipse Java code formatter
 eclipse-jdt - Java Development Tools plug-ins for Eclipse
 eclipse-jdt-common - Java Development Tools plug-ins for Eclipse (common files)
 eclipse-jdt-gcj - Java Development Tools plug-ins for Eclipse (GCJ version)
 eclipse-pde - Plug-in Development Environment to develop Eclipse plug-ins
 eclipse-pde-common - Plug-in Development Environment to develop Eclipse plug-ins (comm
 eclipse-pde-gcj - Plug-in Development Environment to develop Eclipse plug-ins (GCJ 
 eclipse-platform - Eclipse platform without plug-ins to develop any language
 eclipse-platform-common - Eclipse platform without plug-ins to develop any language (common
 eclipse-platform-gcj - Eclipse platform without plug-ins to develop any language (GCJ ve
 eclipse-rcp - Eclipse rich client platform
 eclipse-rcp-common - Eclipse rich client platform (common files)
 eclipse-rcp-gcj - Eclipse rich client platform (GCJ version)
 eclipse-sdk - Extensible Tool Platform and Java IDE
 eclipse-source - Eclipse source code plug-ins
 libswt3.1-gtk-java - Fast and rich GUI toolkit for Java, gtk2 version
 libswt3.1-gtk-jni - Platform dependent files for libswt3.1-gtk-java
Closes: 345724 345749 345756 346110 346224
Changes: 
 eclipse (3.1.1-8) unstable; urgency=low
 .
   * debian/eclipse-platform.preinst: Make /usr/lib/eclipse/features a real
     directory. Closes: #345724, #345749, #346224
   * debian/rules: Don't make /usr/lib/eclipse/features a symlink.
   * debian/eclipse-platform.install: Include only the non-source features.
   * debian/rules: Handle eclipse architures with the same name as the
     according Debian architures correctly.
   * debian/rules: Don't re-define CURDIR. It's defined by make.
   * debian/rules: Don't overwrite LC_ALL. Not needed.
   * debian/extra/eclipse.sh: Fixed handling of /etc/eclipse/java_home.
     Closes: #345756, #346110
   *
Files: 
 9a8ef255a3b48e04502c2646e4c83766 1511 devel optional eclipse_3.1.1-8.dsc
 658a5a8724f7b91523f42f364173d958 112664 devel optional eclipse_3.1.1-8.diff.gz
 33a1eddf1a3e4b155aea25aadd90045c 4685834 devel optional eclipse-rcp-common_3.1.1-8_all.deb
 44d1bdeea793297ba012bdc97f8ef85f 36115178 devel optional eclipse-platform-common_3.1.1-8_all.deb
 dd4ce8577f9267d3b161161c278ed7b6 22225134 devel optional eclipse-jdt-common_3.1.1-8_all.deb
 4fa60e532bf567d813703f2f4b333e06 5719820 devel optional eclipse-pde-common_3.1.1-8_all.deb
 dbe45fe1505d539165fecf54226d4630 18960 devel optional eclipse-sdk_3.1.1-8_all.deb
 a3e8cdf80265001c630d0f3eaa9b992d 75900 devel optional eclipse_3.1.1-8_all.deb
 a4e3bc7f39043e99b3705953c4337792 30680 devel optional eclipse-ecj_3.1.1-8_all.deb
 fe53102f5a6cf22efe5b1547ba53ff62 19958 devel optional eclipse-rcp_3.1.1-8_i386.deb
 e745b5e26c067c8376e09f2b30cca124 94092 devel optional eclipse-rcp-gcj_3.1.1-8_i386.deb
 f9377175c31b7cc662ea51fc7a655d3f 46098 devel optional eclipse-platform_3.1.1-8_i386.deb
 6023568cf89bd7240ebe84a57257d503 189762 devel optional eclipse-platform-gcj_3.1.1-8_i386.deb
 c97e8ae6c94d2844cf363e34905620a8 19302 devel optional eclipse-jdt_3.1.1-8_i386.deb
 3c9368690c5d6879c4b8d4050e13aa6b 159114 devel optional eclipse-jdt-gcj_3.1.1-8_i386.deb
 68777ceb2de0faf038d1e24404c31374 19142 devel optional eclipse-pde_3.1.1-8_i386.deb
 dc4ace362230fb35edfd80f0972ac0e3 61750 devel optional eclipse-pde-gcj_3.1.1-8_i386.deb
 e5e6efe0d6d996f98db0074e33047ac3 25719702 devel optional eclipse-source_3.1.1-8_i386.deb
 706ffac63c74baf69f8d6b82e35d8c49 1338738 devel optional libswt3.1-gtk-java_3.1.1-8_i386.deb
 348587c5701e12bb12b1bbaa9074c32b 174438 devel optional libswt3.1-gtk-jni_3.1.1-8_i386.deb
 a9cf40d8c014e7027285adcc2aa54665 1668514 devel optional eclipse-ecj-gcj_3.1.1-8_i386.deb
 7dcbc986ae7e43f9a54fc8529230de9e 19212 devel optional eclipse-efj_3.1.1-8_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDv8cyWSOgCCdjSDsRAkb9AJ0YZy9LuifpsnKgBZdwm6paSyWxWwCdHPpl
9Fn9+tQlMuJStXNon/3zo8Q=
=FmSk
-----END PGP SIGNATURE-----

More information about the pkg-java-maintainers mailing list