RFC: jcommon-1.0.5

[Arnaud Vandyck]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Schuster wrote:
> Hi,
> lets start simple.
> 
> This patch updates libjcommon-java to 1.0.5 and makes it use java-gcj-compat-dev
> and ecj-bootstrap for building.
> 
> Comments?

Thanks...

> Index: libjcommon-java/debian/control
> ===================================================================
> --- libjcommon-java/debian/control	(Revision 2278)
> +++ libjcommon-java/debian/control	(Arbeitskopie)
> @@ -3,13 +3,13 @@
>  Priority: optional
>  Maintainer: Debian Java Maintainers <pkg-java-maintainers at lists.alioth.debian.org>
>  Uploaders: Christian Bayle <bayle at debian.org>, Wolfgang Baer <WBaer at gmx.de>
> -Build-Depends-Indep: debhelper (>= 4.2.30), cdbs, kaffe, ant
> +Build-Depends-Indep: debhelper (>= 4.2.30), cdbs, java-gcj-compat-dev, ecj-bootstrap, ant, libservlet2.4-java

This should be break into Build-Depends (cdbs and debhelper) and
Build-Depends-Indep for the rest

>  Standards-Version: 3.6.2

Should be updated to 3.7.2

[...]

> -Depends: kaffe | java1-runtime | java2-runtime
> +Depends: java-gcj-compat | java1-runtime1 | java2-runtime

[...]

> Index: libjcommon-java/debian/rules
> ===================================================================

[...]

> -DEB_JARS := $(ANT_HOME)/lib/ant-launcher.jar
> +DEB_JARS := \
> +	ant-launcher \

No more needed with current version of cdbs

> +	junit \
> +	servlet-api-2.4
> +
> +# Build compiler
> +DEB_ANT_COMPILER := org.eclipse.jdt.core.JDTCompilerAdapter
> +ifneq (,$(findstring eclipse,$(DEB_ANT_COMPILER)))
> +    DEB_JARS += ecj.jar /usr/share/ant/lib/ecj-adapter.jar
> +endif

I think it's the default gcj compiler, isn't it?

[...]

> Index: libjcommon-java/debian/ant.properties
> ===================================================================
[...]

Good work.

I'm correcting some parts and I'll upload the new upstream.

Many thanks for your work.

- --
  .''`.
 : :' :rnaud
 `. `'
   `-
Java Trap: http://www.gnu.org/philosophy/java-trap.html
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEvgmr4vzFZu62tMIRAkB/AJsE2rFV0m61veqYL2vhOOdYJ3apjgCglhRg
GMFElf94tZHIMqvMVcMRBJY=
=vAd7
-----END PGP SIGNATURE-----