Bug#346364: Two patches: extended java_home (for sun-java6-jre) or better check for JVM

[Michael Koch]

Hello,


On Fri, Oct 19, 2007 at 02:32:44AM +0200, Kai Wb. wrote:
> tags 346364 confirmed patch
> thanks

Please dont confirm bugs if you are not the package maintainer. Thanks.

> The first patch attached to this mail adds the JVM provided by the sun-java6-jre
> to the search-path under /etc/eclipse/java_home

That was fixed in 3.2.2-2 finally. When creating patches please do them
against the latest version to avoid duplicate work.

> But wouldn't it be better to default to the value provided by
> /etc/alternatives/java (or at least check if it's available)? This should keep
> you/us out of trouble and you don't need to maintain a list of JVMs.
> Alternatively (or additionally) you could also check for the .*.jinfo-file under
> /usr/lib/jvm/ which should be generated by /usr/sbin/update-java-alternatives
> (provided by the package java-common). There should be (if a JRE/JDK is
> installed) a line like
> > jre java /usr/lib/jvm/java-6-sun/jre/bin/java
> In the attachment you find a patch for /usr/bin/eclipse which adds these two
> options (but I must admit that I hadn't time to test it). I think it's not quite
> beautiful and you can shorten it if you try to determine JAVACMD directly
> because /etc/alternatives and the line from the *.jinfo-file point directly to
> the executable.
> In any case it should run without errors (at least it had done so on my bash).
> 
> In #347254 it is said that this problem is fixed but this bug is open (and I
> find that justified). So I would suggest to reopen #347254 and mark one of them
> as the duplicate of the other (or have I misunderstood something in the BTS?).

> 
> Greetings,
> Kai
> 
> P.S.: I've tagged this as "patched", but I haven't tested these patches
> (particularly the one which alters /usr/bin/eclipse) thoroughly. I hope that's
> ok, if not, feel free to remove the tag (in this case: sorry for being to fast *g*).

The patch is against some file installed in the system. When creating
patches please do them against the latest source package.

I will leave this bug report closed as its fixed already.


Cheers,
Michael