[RFR] templates://solr/{solr-common.templates}

Christian Perrier bubulle at debian.org
Sun Sep 16 06:43:40 UTC 2007


Please find, for review, the debconf templates and packages descriptions for the solr source package.

This review will last from Sunday, September 16, 2007 to Wednesday, September 26, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../solr.old/debian/solr-common.templates	2007-09-14 08:56:34.967674181 +0200
+++ debian/solr-common.templates	2007-09-15 10:57:15.088922852 +0200
@@ -1,8 +1,9 @@
 Template: solr/purgeindexfiles
 Type: boolean
 Default: false
-_Description: Remove index files?
- The script is about to remove the data directory /var/lib/solr.
- If you think you need Solr's index files later, the data
- should be kept.
-
+_Description: Remove Solr index files?
+ The Solr data directory (/var/lib/solr) may be removed while purging the
+ package.
+ .
+ You should not choose this option if you intend to re-use Solr's index
+ files later.

Be more specific about *what* index files are to be removed. The
removal could happen during a batch of removals.

I also propose to extend the long description and use a quite common
wording. The purpose is being very clear about what is about to happen.


--- ../solr.old/debian/control	2007-09-14 08:56:34.967674181 +0200
+++ debian/control	2007-09-15 10:55:41.593717850 +0200
@@ -28,14 +28,14 @@
  liblucene2-java (>= 2.2),
  libxpp3-java
 Recommends: solr-tomcat5.5 (>= ${binary:Version}) | solr-jetty (>= ${binary:Version})
-Description: enterprise search server based on Lucene (common files)
+Description: enterprise search server based on Lucene - common files

Use the common "family description - specific description" style

  Solr is an open source enterprise search server based on the Lucene 
  Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
  faceted search, caching, replication, and a web administration 
  interface. It runs in a Java servlet container such as Tomcat.
  .
- Common files for Solr. Install solr-tomcat5.5 or solr-jetty to use Solr under
- Tomcat or Jetty.
+ This package provides the common files for Solr. Install
+ solr-tomcat5.5 or solr-jetty to use Solr under Tomcat or Jetty.

The first "sentence" wasn't a sentence, so use the common "This
package provides <foo>" wording.


  .
   Homepage: http://lucene.apache.org/solr/
 
@@ -43,13 +43,13 @@
 Architecture: all
 Depends: solr-common (>= ${binary:Version}), tomcat5.5
 Conflicts: solr-jetty
-Description: enterprise search server based on Lucene (Tomcat integration)
+Description: enterprise search server based on Lucene - Tomcat integration


cf supra

  Solr is an open source enterprise search server based on the Lucene 
  Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
  faceted search, caching, replication, and a web administration 
  interface. It runs in a Java servlet container such as Tomcat.
  .
- This package contains the Tomcat integration files for Solr. 
+ This package provides the Tomcat integration files for Solr. 

cf supra


-------------- next part --------------
Template: solr/purgeindexfiles
Type: boolean
Default: false
_Description: Remove Solr index files?
 The Solr data directory (/var/lib/solr) may be removed while purging the
 package.
 .
 You should not choose this option if you intend to re-use Solr's index
 files later.
-------------- next part --------------
--- ../solr.old/debian/solr-common.templates	2007-09-14 08:56:34.967674181 +0200
+++ debian/solr-common.templates	2007-09-15 10:57:15.088922852 +0200
@@ -1,8 +1,9 @@
 Template: solr/purgeindexfiles
 Type: boolean
 Default: false
-_Description: Remove index files?
- The script is about to remove the data directory /var/lib/solr.
- If you think you need Solr's index files later, the data
- should be kept.
-
+_Description: Remove Solr index files?
+ The Solr data directory (/var/lib/solr) may be removed while purging the
+ package.
+ .
+ You should not choose this option if you intend to re-use Solr's index
+ files later.
--- ../solr.old/debian/control	2007-09-14 08:56:34.967674181 +0200
+++ debian/control	2007-09-15 10:55:41.593717850 +0200
@@ -28,14 +28,14 @@
  liblucene2-java (>= 2.2),
  libxpp3-java
 Recommends: solr-tomcat5.5 (>= ${binary:Version}) | solr-jetty (>= ${binary:Version})
-Description: enterprise search server based on Lucene (common files)
+Description: enterprise search server based on Lucene - common files
  Solr is an open source enterprise search server based on the Lucene 
  Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
  faceted search, caching, replication, and a web administration 
  interface. It runs in a Java servlet container such as Tomcat.
  .
- Common files for Solr. Install solr-tomcat5.5 or solr-jetty to use Solr under
- Tomcat or Jetty.
+ This package provides the common files for Solr. Install
+ solr-tomcat5.5 or solr-jetty to use Solr under Tomcat or Jetty.
  .
   Homepage: http://lucene.apache.org/solr/
 
@@ -43,13 +43,13 @@
 Architecture: all
 Depends: solr-common (>= ${binary:Version}), tomcat5.5
 Conflicts: solr-jetty
-Description: enterprise search server based on Lucene (Tomcat integration)
+Description: enterprise search server based on Lucene - Tomcat integration
  Solr is an open source enterprise search server based on the Lucene 
  Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
  faceted search, caching, replication, and a web administration 
  interface. It runs in a Java servlet container such as Tomcat.
  .
- This package contains the Tomcat integration files for Solr. 
+ This package provides the Tomcat integration files for Solr. 
  .
   Homepage: http://lucene.apache.org/solr/
 
@@ -57,12 +57,12 @@
 Architecture: all
 Depends: solr-common (>= ${binary:Version}), jetty (>= 5.1)
 Conflicts: solr-tomcat5.5
-Description: enterprise search server based on Lucene (Jetty integration)
+Description: enterprise search server based on Lucene - Jetty integration
  Solr is an open source enterprise search server based on the Lucene 
  Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
  faceted search, caching, replication, and a web administration 
  interface. It runs in a Java servlet container such as Tomcat.
  .
- This package contains the Jetty integration files for Solr. 
+ This package provides the Jetty integration files for Solr. 
  .
   Homepage: http://lucene.apache.org/solr/
-------------- next part --------------
Source: solr
Section: contrib/text
Priority: optional
Maintainer: Debian Java Maintainers <pkg-java-maintainers at lists.alioth.debian.org>
Uploaders: Jan-Pascal van Best <janpascal at vanbest.org>
XS-Vcs-Browser: http://svn.debian.org/wsvn/pkg-java/trunk/solr/
XS-Vcs-svn: svn://svn.debian.org/svn/pkg-java/trunk/solr/
Build-Depends: cdbs, debhelper (>= 4.1.0), dpatch (>= 2.0), po-debconf,
 sun-java5-jre, sun-java5-jdk, ant, ant-optional, junit,
 libcommons-codec-java,
 libcommons-csv-java,
 libcommons-fileupload-java (>= 1.2),
 libcommons-io-java,
 libservlet2.4-java,
 liblucene2-java (>= 2.2),
 libxpp3-java
Standards-Version: 3.7.2

Package: solr-common
Architecture: all
Depends: debconf (>= 1.5),
 sun-java5-jre | sun-java6-jre,
 libcommons-codec-java,
 libcommons-csv-java,
 libcommons-fileupload-java (>= 1.2),
 libcommons-io-java,
 libservlet2.4-java,
 liblucene2-java (>= 2.2),
 libxpp3-java
Recommends: solr-tomcat5.5 (>= ${binary:Version}) | solr-jetty (>= ${binary:Version})
Description: enterprise search server based on Lucene - common files
 Solr is an open source enterprise search server based on the Lucene 
 Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
 faceted search, caching, replication, and a web administration 
 interface. It runs in a Java servlet container such as Tomcat.
 .
 This package provides the common files for Solr. Install
 solr-tomcat5.5 or solr-jetty to use Solr under Tomcat or Jetty.
 .
  Homepage: http://lucene.apache.org/solr/

Package: solr-tomcat5.5
Architecture: all
Depends: solr-common (>= ${binary:Version}), tomcat5.5
Conflicts: solr-jetty
Description: enterprise search server based on Lucene - Tomcat integration
 Solr is an open source enterprise search server based on the Lucene 
 Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
 faceted search, caching, replication, and a web administration 
 interface. It runs in a Java servlet container such as Tomcat.
 .
 This package provides the Tomcat integration files for Solr. 
 .
  Homepage: http://lucene.apache.org/solr/

Package: solr-jetty
Architecture: all
Depends: solr-common (>= ${binary:Version}), jetty (>= 5.1)
Conflicts: solr-tomcat5.5
Description: enterprise search server based on Lucene - Jetty integration
 Solr is an open source enterprise search server based on the Lucene 
 Java search library, with XML/HTTP and JSON APIs, hit highlighting, 
 faceted search, caching, replication, and a web administration 
 interface. It runs in a Java servlet container such as Tomcat.
 .
 This package provides the Jetty integration files for Solr. 
 .
  Homepage: http://lucene.apache.org/solr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-java-maintainers/attachments/20070916/be98ccbe/attachment-0001.pgp 


More information about the pkg-java-maintainers mailing list