Bug#474908: cdk: FTBFS: NomParserTokenManager cannot be resolved to a type

[Paul Cager]

Michael Koch wrote:
> On Mon, Apr 07, 2008 at 10:33:32PM +0200, Lucas Nussbaum wrote:
>> Package: cdk
>> Version: 1:1.0.2-1
>> Severity: serious
>> User: debian-qa at lists.debian.org
>> Usertags: qa-ftbfs-20080407 qa-ftbfs
>> Justification: FTBFS on i386
>>
...
> This broken with the last javacc update. Teh Nom*.java classes are
> generated from NomParser.jj.
> 
> Paul can you please take a look at this?

Thanks for finding this problem, Lucas.

cdk looks to have an interesting build system - it compiles a Java 
program (MakeJavafilesFiles.java) which is then used to copy the source 
files into a build directory. But MakeJavafilesFiles spits out the error 
message "Something wrong with the Java source file: 
src/org/openscience/cdk/iupac/parser/NomParserTokenManager.java".

The reason is because JavaCC is generating comments such as:

    /** Token Manager. */

CDK's MakeJavafilesFiles program looks at program sources to detect 
special "@cdk.set" tags in them. But there is a bug in the part of 
MakeJavafilesFiles that is meant to recognise comments - it doesn't 
recognise the comment terminator "*/" if the comment was introduced with 
"/**" on the same line.

I'll probably patch cdk so that it recognises "*/" in this context, but 
also "fix" JavaCC upstream (change the comment terminator to be "**/").

Thanks,
Paul