Bug#504425: Please fix these packaging problems

[Onkar Shinde]

On Tue, Nov 4, 2008 at 6:14 AM, Varun Hiremath <varunhiremath at gmail.com> wrote:
> Hello Onkar,
>
> On Tue, 04 Nov, 2008 at 01:39:38AM +0530, Onkar Shinde wrote:
>> Package: jftp
>> Version: 1.51~pre4-2
>>
>> I was planning to port the packaging changes I did in Ubuntu for jftp
>> to Debian this week. But Varun has already done most of the changes in
>> 1.51~pre4-2 (in NEW queue). Following are some changes I believe are
>> still remaining. All comments welcome.
>>
>> 1. debian/control
>> Remove unneeded build and runtime dependency libjorbis-java.
>> Modify JRE dependencies to openjdk-6-jre | java5-runtime | java6-runtime.
>> 2. debian/jftp.run
>> Remove hard coded path to openjdk java binary. Instead simply use -
>> java -jar /usr/share/java/jftp.jar "$@"
>
> jftp doesn't load with java-gcj and some of the other free JREs. It
> only works with sun jre and openjdk jre. Did you try running jftp with
> other JREs?
>
> I get this error, when I try to run jftp with java-gcj:
>
> Exception in thread "main" java.lang.NullPointerException
>   at net.sf.jftp.gui.base.StatusPanel.<init>(StatusPanel.java:79)
>   at net.sf.jftp.JFtp.init(JFtp.java:180)
>   at net.sf.jftp.JFtp.<init>(JFtp.java:166)
>   at net.sf.jftp.JFtp.main(JFtp.java:574)
>
> I haven't tried debugging into this, but I guess jftp uses some swing
> classes which don't work with java-gcj.

I tried only with Sun JRE and OpenJDK. But I still believe it is
better to not hard code the path. If at some points GCJ implements all
the Swing classes used by jftp it will automatically start working. We
won't have to keep watch on if GCJ or any other Free JRE is good
enough to run jftp and then change the jftp startup script
accordingly.
Another point of view is that GCJ developers may get some help with
bugs about certain app not working with it.

>> 3. debian/manifest.mf
>> Remove jorbis.jar and jogg.jar from class path.
>> 4. debian/rules
>> Remove jorbis and jogg from DEB_JARS.
>
> Hmm.. not sure why we added those jars, but yes they can be removed
> now. Thanks.
>
>> 5. debian/README.debian
>> Add to comply with 3.8.0 standards version.
>
> Do you mean README.source? We have a README.Debian-source file and I
> think it should be renamed to README.source according to 3.8.0
> standards.

Yes, I meant the README.source.
The README.Debian-source file that is currently present talks about
the modification of upstream tarball i.e. removal of jar and class
files.
The README.source file should talk about the patch system used and how
to obtained the patched source. I am referring to
https://wiki.ubuntu.com/README.sourceHowTo. Please correct me if I am
wrong.


Onkar