Bug#402340: browser support not working on upgrading from eclise 3.1.2 to eclipse 3.2.1

[Niels Thykier]

Kiss Karoly wrote:
> Package: eclipse
> Version: 3.4.1-1
> Severity: normal
> 
> 
> Looking at /usr/bin/eclipse line 132-135 shows:
> ------ SNIP -----
> MOZILLA_FIVE_HOME=${MOZILLA_FIVE_HOME%*/}
> if false && [ -n "$MOZILLA_FIVE_HOME" -a -e $MOZILLA_FIVE_HOME/libgtkembedmoz.so ]; then
>     :
> elif [ -e /usr/lib/mozilla/libgtkembedmoz.so ]; then
> ------ SNIP -----
> 
> The problem is that having a conditional false && something always gives a false result.
> The developer probably intended false || something.
> That way simply exporting MOZILLA_FIVE_HOME in a shell before starting eclipse would enable
> the user to specify the location of the libgtkembedmoz.so he would like to use.
> 

Hi

Thanks for notifying of this.

I think this was a "quick" way of "lets disable this", that never got
enabled again (or cleaned up). Namely because "false || something"
always yields "something", so there would no point in doing "false ||
something".

Though, please note that due to way it is programmed, if you see this
warning, then setting MOZILLA_FIVE_HOME is actually considered (since it
is pre-appended to LD_LIBRARY_PATH regardless) - so setting it ought to
have an effect[1].

That being said I intend to remove that part, since it does not properly
handle nor detect the xulrunner libraries, which (I believe are detected
by the settings in /etc/gre.d/* - or at the very least remove the warning.

As far as I can tell, the internal browser works just fine on my machine
and I get that annoying warning.

~Niels

[1] at least assuming you do not have /etc/gre.d/*. Not sure how eclipse
handles having that and a mozilla lib in LD_LIBRARY_PATH.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-java-maintainers/attachments/20090820/335ec3af/attachment.pgp>