Bug#551066: javahelp2: Missing icons causes some options to be hidden

[Sylvestre Ledru]

Hello,

Le jeudi 15 octobre 2009 à 14:28 -0400, Varun Hiremath a écrit :
> Hi Sylvestre,
> 
> See my replies to both your bug reports below.
> 
> On Thu, 15 Oct, 2009 at 12:13:46PM +0200, Sylvestre Ledru wrote:
> > Package: javahelp2
> > Version: 2.0.05.ds1-1
> > Severity: normal
> > 
> > Hello,
> > 
> > Trying to have a look on the source code of javahelp, I retrieved the debian
> > source with:
> > apt-get source javahelp2
> > 
> > The list of the directories is the following one:
> > debian              jhMaster                 JSearchIndexer_nbproject
> > javahelp_nbproject  JSearchClient_nbproject
> > 
> > When I tried to get through uscan upstream jh2.0.zip
> > the content of the source package is completely different:
> > demos  doc  javahelp  LICENSE.html  README  README.html  src.jar
> > 
> > It is no big deal but there should be a debian/README.source explaining:
> > * what are the differences
> > * how it can be done again
> > (and a repack script would be great)
> > 
> > The only reference I can found is in the changelog and is:
> > "* Remove zip archive from orig.tar.gz and repackage"
> 
> Sorry for the confusion.
> 
> 1/ The original source is actually available here (also mentioned in
> debian/copyright) which matches with debian source:
> https://javahelp.dev.java.net/files/documents/5985/59373/javahelp2-src-2.0.05.zip
> 
> 2/ uscan is using some other site to track the upstream-version; I have
> added a comment now to clarify this.
> 
> 3/ The original source for version 2.0.05 was packaged by Marek Slama
> (CC:ed) which included the zip file inside the orig.tar.gz, which I
> unpackaged in version 2.0.05.ds1 because it was causing some build
> issues.
OK, thanks for the feedback.

> On Thu, 15 Oct, 2009 at 01:53:03PM +0200, Sylvestre Ledru wrote:
> > Package: javahelp2
> > Version: 2.0.05.ds1-1
> > Severity: important
> > 
> > Hello,
> > 
> > When I am using a documentation based on the javahelp2 browser, I cannot see
> > any icons. This renders many options of javahelp2 to be unsuable.
> > 
> > It is due to an error in the repack of the javahelp sources.
> > The fix is pretty easy.
> > 1) download upstream archive
> > 2) unpack src.jar inside
> > 3) Copy the missing files
> > cp -R javahelp2-upstream/src/javax/help/plaf/basic/images/ javahelp2-debian-dir/jhMaster/JavaHelp/src/new/javax/help/plaf/basic/
> > cp -R javahelp2-upstream/src/javax/help/plaf/gtk/images/ javahelp2-debian-dir/jhMaster/JavaHelp/src/new/javax/help/plaf/gtk/
> 
> I am not sure if the License for these images is DFSG compatible. The
> LICENSE.html says "Sun Microsystems, Inc. Binary Code License
> Agreement". I guess they were removed from debian source due to
> license issues, but may be Marek Slama can clarify about this.
OK. I understand. 
Anyway, an alternative can be to use an other icon set. It is going to
be very easy to find remplacement (I can do that if you want).

Thanks for the quick answers,
Sylvestre

> Thanks,
> Varun