Bug#575580: tomcat6-user: tomcat6-instance-create fails when multiple commandline options are provided

[Mark Scott]

Package: tomcat6-user
Version: 6.0.24-3
Severity: important

Try to pass both the -p and -c options:

$ tomcat6-instance-create -p 8050 -c 8006 tomcat6
You are about to create a Tomcat instance in directory '-c'
[snip much error output]

Only the first option is parsed correctly and the target directory is always
assigned the value of $3.  The problem is in the 'getopts' handling and is
fixed by patching with this diff:

*** /tmp/tomcat6-instance-create.diff
*** /usr/bin/tomcat6-instance-create	2009-03-02 21:45:29.000000000 +0000
--- ./tomcat6-instance-create	2010-03-27 08:15:40.721704619 +0000
***************
*** 64,81 ****
  
  while getopts ":p:c:w:h" options; do
    case $options in
!     p ) HPORT=$OPTARG
! 	shift; shift ;;
!     c ) CPORT=$OPTARG
! 	shift; shift ;;
!     w ) CWORD=$OPTARG
! 	shift; shift ;;
      h ) usage;;
      * ) echo "Error: Unknown parameter '$OPTARG'."
          exit 1;;
    esac
  done
  
  TARGET=$1
  shift
  echo "You are about to create a Tomcat instance in directory '$TARGET'"
--- 64,79 ----
  
  while getopts ":p:c:w:h" options; do
    case $options in
!     p ) HPORT=$OPTARG ;;
!     c ) CPORT=$OPTARG ;;
!     w ) CWORD=$OPTARG ;;
      h ) usage;;
      * ) echo "Error: Unknown parameter '$OPTARG'."
          exit 1;;
    esac
  done
  
+ shift $(($OPTIND - 1))
  TARGET=$1
  shift
  echo "You are about to create a Tomcat instance in directory '$TARGET'"


-- System Information:
Debian Release: 5.0.4
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages tomcat6-user depends on:
ii  netcat                        1.10-38    TCP/IP swiss army knife -- transit
ii  netcat-traditional [netcat]   1.10-38    TCP/IP swiss army knife
ii  tomcat6-common                6.0.24-3   Servlet and JSP engine -- common f

tomcat6-user recommends no packages.

Versions of packages tomcat6-user suggests:
ii  tomcat6                       6.0.24-3   Servlet and JSP engine
pn  tomcat6-admin                 <none>     (no description available)
pn  tomcat6-docs                  <none>     (no description available)
pn  tomcat6-examples              <none>     (no description available)

-- no debconf information