Bug#581099: eclipse-pde: bashism in /bin/sh script

[Raphael Geissert]

Package: eclipse-pde
Severity: important
Version: 3.5.2-3
User: debian-release at lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing a /bin/sh script making use
of a bashism.

checkbashisms' output:
> possible bashism in
> ./usr/lib/eclipse/plugins/org.eclipse.pde.build_3.5.2.R35x_20100114/templat
> es/package-build/prepare-build-dir.sh line 47 (should be 'b = a'):
>   if [ $inSDK == 0 ]; then
> possible bashism in
> ./usr/lib/eclipse/plugins/org.eclipse.pde.build_3.5.2.R35x_20100114/templat
> es/package-build/prepare-build-dir.sh line 60 (alternative test command ([[
> foo ]] should be [ foo ])):
>	if [[ $TESTING != true || `echo $PROJECTNAME | grep "org.eclipse"`
> ]]; then
> possible bashism in
> ./usr/lib/eclipse/plugins/org.eclipse.pde.build_3.5.2.R35x_20100114/templat
> es/package-build/prepare-build-dir.sh line 75 (should be 'b = a'):
>   if [ $inSDK == 0 ]; then
> possible bashism in
> ./usr/lib/eclipse/plugins/org.eclipse.pde.build_3.5.2.R35x_20100114/templat
> es/package-build/prepare-build-dir.sh line 94 (alternative test command ([[
> foo ]] should be [ foo ])):
>	if [[ $TESTING != true || `echo $PROJECTNAME | grep "org.eclipse"`
> ]]; then


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is now the default /bin/sh.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

If you still don't know how to fix the bashisms don't hesitate to reply to
this email, or tag the bug as 'help'.

Thank you,
Raphael Geissert