Bug#626382: jetty: init script doesn't follow policy: start returns error if already running

[Toby]

Package: jetty
Version: 6.1.22-1ubuntu1
Severity: normal
Tags: patch


According to Debian policy:

"The init.d scripts must ensure that they will behave sensibly (i.e.,
returning success and not starting multiple copies of a service) if
invoked with start when the service is already running, [...]"

However, the jetty init.d script does not do this. If jetty is running,
and we do "/etc/init.d/jetty start" (or restart) then an exit code of
1 is returned (so it looks like the command failed).

This patch fixes the issue:

--- debian/jetty.init.old	2011-05-11 14:18:34.896857829 +0100
+++ debian/jetty.init	2011-05-11 14:18:53.896857970 +0100
@@ -316,7 +316,6 @@
 	else
 		log_warning_msg "(already running)."
 		log_end_msg 0
-		exit 1
 	fi
 	;;
 

-- System Information:
Debian Release: squeeze/sid
  APT prefers lucid-updates
  APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500, 'lucid')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-28-generic (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages jetty depends on:
ii  adduser      3.112ubuntu1                add and remove users and groups
ii  apache2-util 2.2.14-5ubuntu8.4           utility programs for webservers
ii  jsvc         1.0.2~svn20061127-10ubuntu1 wrapper to launch Java application
ii  libjetty-jav 6.1.22-1ubuntu1             Java servlet engine and webserver 
ii  libjetty-jav 6.1.22-1ubuntu1             Javadoc for the Jetty API

jetty recommends no packages.

Versions of packages jetty suggests:
ii  libjetty-extra           6.1.22-1ubuntu1 Java servlet engine and webserver 
ii  libjetty-extra-java      6.1.22-1ubuntu1 Java servlet engine and webserver 

-- no debconf information