Bug#644260: cleanup / update java code

[Thomas Koch]

Package: maven-repo-helper
Version: 1.6
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

so I'll be as critic with our Debian Java code as I am with upstream's code...

I'd propose (and like to do) some updates / cleanups to the java code:

* use generics
* replace
  for (Iterator i = pomList.iterator(); i.hasNext(); )
  for ( String pomPath : pomList )
* In general avoid global state in the class but let the methods return results
* Use a library to parse commandline parameters
* Use constants instead of inline Strings
* Use resources for long texts
* Methods should not have more then 3-5 parameters
* Methods should not be too long
* conditionals (if, loops) should not be nested too deep
* Old code should be deleted instead of commented. Rather switch to a sane VCS. :-)
* Add comments to help people understand the code (after some refactoring has
  been done...)

Does anybody know an XML library that could help to have minimal changes to
upstream's pom.xml? Currently one couldn't see much in a diff between pom.xml
and pom.xml.save.

Actually I started diving into maven-repo-helper because it somehow deleted a
dependency from a project I want to package (jgit)...

Best Regards, Thomas Koch

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOixyWAAoJEAf8SJEEK6ZaZRwP/2zFljMbVWI0UTYGHSi7VAc6
B4ZJfPRmDP5eWN4EEofVlZus+R7WVeTtqwLlhSrILDkplU2XeZKaUDLNX8hFrJlf
fD6+BsRCOXqtfgAFI4BnirzlXEDJQfpAkevvtuiK6TNJtot+dP2RFpLj631YFaDo
ziWf8lxz8Lcld9c9kRvxeEmRiLiuBFBXPqhvUbGr8wQmuADtfsoBwAT9Ujat2fVw
woBUK2zTCjqlpQ1v9+ie5uKZKrsJSeTxro+Rm6Kha1swFOUXWCUDdO5rI4aG7+b7
4gqyKSATFftDpFiR8OGXjnJylF5q5baFbIKNT4S8OHScbV8lbPaMnAUW13UbLBLA
WqGxTvGWBL2G0h4RNrR5UlzGh865OgAdPO+7HoieWqSlWUDOQfuU5ZzJZYv28Zrk
ybXRlRFt2hBH3LTTOYzqLPrkuulZbx7blydNBaAw89zKeCUQIXeB7UHatr3hyS0p
ND4/yacB5VZlp8DT0YGFZqTgy0iG9Z5QuFrfUbQr5b1Kc3qhl6XAbTy+Z9I7D4d3
Mu/34ricVzCObM8HrYl7JhziWU1TuhnxentpplXXVhOWblxGzkoc3yV59o78mpyB
SBlu8IZOR5XkU/iZ1QBhDG/EWM7BA274sMYZ94HkVDD2/7jTsGZ0SG0cmMKMkxm8
rjPTPOsSecZ4VroNtbrw
=toSZ
-----END PGP SIGNATURE-----