Bug#673147: clean up java code

[Thomas Koch]

Package: maven-debian-helper
Version: 1.5.1
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

The current state of the java code ... could be improved. A nicer code base is
more fun to improve and hack on.

After a first glance I'd like to do the following:

- - use modern for loops: for (item:items)

- - use immutability as much as possible

- - separate command line option parsing in a separate class (and maybe later use
  a library for option parsing)

- - avoid long methods and deeply nested conditions or loops

- - separate logic from IO and user interaction

Please tell me, if you're fine with changes like that. I'm normally following
advises from Joshua Blochs "Effective Java".

Regards, Thomas Koch


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPs6aVAAoJEAf8SJEEK6Za71YP/iLY4o9XHB75xjr3dxBgUWEr
lTnVRVGeIOZxFK3BmV6JSKO1UyWr1GV0HBd1CjQjC+Z9q4seyj1sVSzvjLVycC9l
xIQCqyEzIWcaMWHNSqnLfb6EkagNG1CCqM6V1C5NIkT/RQta5RE5vrvzKcPFOK6s
JfWLMVozliiU9YLk+WNo/PQ19JUZcQjRDlTGO3Ewm9mWPNq8zreM4YFoGarSW+yr
XEl7yRrhn+U8LKxtMEKiUxS/fwhk3BXa7q78paTzbdyhCxw0R6p/FufdoxfgyQ8Y
Pplq8eiYVtpII0izi9hD52+VsWyTKOuRwBJR/nr9fE0HwZegLS39mTfn5RAMazBa
v7iEW7+Vu7HYv4m24B/Nv5y5/b8LfEpOszsqlQh9CO+BqDhkgz1bpsIh7sr2FtiX
Y00DP5loMEWV9lp+PWC2+MEp/1kLSRssjj+wNL5cw4FMXuHg+HkQWfSnGGVcOYMV
ZAGPsnxn7AJbOHC2qc0zyNHIjGedCQXqqrakTRAHUIlqtSXO8QkDqdpRKmVmTdiU
udrTgD6oYnVlg0stg9GS6c7bFk47NtGaKX5i2rbp6mn6989faXHKTm+ooY38yoSF
v1mKQJOO4MWzi5YYthE8f8O1r1KrX2d21eRDZ1xPvrBtvcR/XCE7PaMaW1St97Ds
BOoNupgUkSSSjDqDS432
=MoVD
-----END PGP SIGNATURE-----