Bug#673765: dom4j FTBFS with openjdk-7
james.page at ubuntu.com
Wed May 23 08:19:49 UTC 2012
-----BEGIN PGP SIGNED MESSAGE-----
On 23/05/12 07:27, Niels Thykier wrote:
> However, I must admit I am a bit concerned in the use of of "!="
> with reals (floats/doubles). To my understanding (in at least
> C/C++) that is very likely to always be true due to even minor
> rounding errors. Presumably this is why upstream used
> "Math.round" in the first place. It is possible that it only apply
> to expressions (and not stored values in variables) or Java handles
> this better, but in this case, I believe a comment in the code
> documenting this assertion would be prudent.
I had the same concern when writing this patch but reading into this
in a bit more detail I decided that this was actually OK for the
The priority (see ) is always one of four values:
I did a quick check and all four of these values can be represented
accurately in Java (this is not true of all float/double literals).
I'll update the patch with an appropriate comment to this effect.
Ubuntu Core Developer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the pkg-java-maintainers