Bug#772010: libini4j-java: Java 8 compatibility patch does not seem correct

[Tomas Safarik]

Package: libini4j-java
Version: 0.5.2-SNAPSHOT-4
Severity: important

I noticed that 01-java8-compatibility.patch seems wrong to me. And not only me,
please have a look at https://bugzilla.redhat.com/show_bug.cgi?id=1087526#c2

Code used in RedHat patch seems more correct to me.

https://kojipkgs.fedoraproject.org//packages/ini4j/0.5.1/12.fc21/src/ini4j-0.5.1-12.fc21.src.rpm

-        return (sec == null) ? null : sec.remove(optionName);
+        if (sec == null) {
+            return false;
+        }
+        if (sec.containsKey(optionName)) {
+            sec.remove(optionName);
+            return true;
+        }
+        return false;

Regards,

Tomas


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash