Bug#745815: libjarjar-java: generate jars with invalid information

[Damien Raude-Morvan]

Hi Miguel, hi Emmanuel !

Sorry to come back to you so late...

2014-05-03 19:50 GMT+02:00 Miguel Landaeta <nomadium at debian.org>:

> On Sat, May 03, 2014 at 07:30:20PM +0200, Emmanuel Bourg wrote:
> > Le 03/05/2014 18:41, Miguel Landaeta a écrit :
> >
> > > Well, the bug was not introduced by upstream as I thought.
> > > I can only reproduce this bug when patch szzepiq_jar_resources.diff is
> applied.
> > > When I remove that patch, jarjar works OK for me.
> >
> > Interesting, the question is to know what issue this patch fixed. There
> > is no mention of a bug in the changelog.
> >
>
> However, the patch itself contains these headers:
>
> Description: Create patch from fork at <URL:
> https://github.com/szczepiq/jarjar>.
>  which resolve the issue with jarjar not updating the fully qualified
> class names
>  in the jar's resources.
>  For instance, with this patch jarjar is able to replace classname (based
> on requested
>  rules) in META-INF/plexus/components.xml files.
> Source: https://github.com/szczepiq/jarjar
> Author: Szczepan Faber
> Author: Damien Raude-Morvan <drazzib at debian.org>
> Last-Update: 2013-01-08
>
> Damien, do you remember what issue fixed this patch in jarjar package?
>
> I think there is a serious issue with this patch. Any file not
> matching .class, .java or MANIFEST.MF ends being treated like a text
> file so it ends modifying .groovy, .png, .properties, anything under
> META-INF, etc.


I've cherry-picked this patch after having issues with some maven plugins
but you're right it might introduce more issues than it solved.
They were repacking themself using jarjar but it won't update references in
META-INF/plexus/components.xml.

As you can see from Gradle debian/changelog :

gradle (1.4-1) unstable; urgency=low
  * d/control: Build-Depends on libjarjar-java (>= 1.4+svn142-1) to build
    Gradle with jarjar which handle correctly updating the fully qualified
    class names in the jar's resources. Otherwise, we get errors during
plexus
    startup.

Maybe recent releases of Gradle might not needed this tricks anymore.

Cheers,
-- 
Damien - Debian Developper
http://wiki.debian.org/DamienRaudeMorvan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-java-maintainers/attachments/20140525/6d918e75/attachment.html>