Bug#820163: mh_resolve_dependencies exception when run with --non-interactive

[Christopher Hoskin]

Package: maven-debian-helper
Version: 2.0.6
Severity: normal

Dear Maintainer,

mh_resolve_dependencies throws an exception when run with the --non-interactive option, unless --no-parent has been set for the pom in debian/.poms

e.g.

~/java/drools-6.3.0$ mh_resolve_dependencies --non-interactive --verbose
dh_listpackages: cannot read debian/control: No such file or directory

Analysing pom.xml...
> dpkg --search /usr/share/maven-repo/org/kie/kie-parent-with-dependencies/*/* 
dpkg failed to execute successfully
> apt-file search /usr/share/maven-repo/org/kie/kie-parent-with-dependencies 
Apr 06, 2016 3:30:12 AM org.debian.maven.packager.DependenciesSolver resolveDependencies
SEVERE: Error while resolving ./pom.xml: Dependency not found org.kie:kie-parent-with-dependencies:pom:6.3.0.Final
Apr 06, 2016 3:30:12 AM org.debian.maven.packager.DependenciesSolver resolveDependencies
SEVERE: 
org.debian.maven.repo.DependencyNotFoundException: Dependency not found org.kie:kie-parent-with-dependencies:pom:6.3.0.Final
	at org.debian.maven.packager.DependenciesSolver.resolveDependency(DependenciesSolver.java:760)
	at org.debian.maven.packager.DependenciesSolver.resolveDependencies(DependenciesSolver.java:306)
	at org.debian.maven.packager.DependenciesSolver.solveDependencies(DependenciesSolver.java:261)
	at org.debian.maven.packager.DependenciesSolver.main(DependenciesSolver.java:960)

(Similar behaviour has been seen running mh_resolve_dependencies in non-interactive mode on other packages)

The underlying problem appears to be that the askIgnoreDependency in maven-packager-utils/src/main/java/org/debian/maven/packager/util/IgnoreDependencyQuestions.java will always return false in non-interactive mode.

My suggested fix would be that askIgnoreDependency should return defaultToIgnore in non-interactive mode (i.e. true in this case) which is what I would consider to be the expected behaviour.

Thanks.

Christopher Hoskin

-- System Information:
Debian Release: stretch/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages maven-debian-helper depends on:
ii  default-jdk                     2:1.8-57
ii  libmaven-clean-plugin-java      2.5-1
ii  libmaven-compiler-plugin-java   3.2-5
ii  libmaven-jar-plugin-java        2.4-1
ii  libmaven-resources-plugin-java  2.6-1
ii  libmaven-site-plugin-java       2.1-4
ii  libplexus-velocity-java         1.1.8-1
ii  libsurefire-java                2.17-2
ii  libxml2-utils                   2.9.3+dfsg1-1
ii  maven                           3.3.9-3
ii  maven-repo-helper               1.8.12
ii  unzip                           6.0-20
ii  velocity                        1.7-4

maven-debian-helper recommends no packages.

Versions of packages maven-debian-helper suggests:
ii  apt-file                      2.5.5
ii  devscripts                    2.16.2
pn  libmaven-javadoc-plugin-java  <none>
ii  subversion                    1.9.3-3

-- no debconf information